Date: Wed, 26 Feb 2014 18:00:01 GMT From: Antoine Brodin <antoine@FreeBSD.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/186982: [PATCH] net/xorp: update to 1.8.5 Message-ID: <201402261800.s1QI01IF026884@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/186982; it has been noted by GNATS. From: Antoine Brodin <antoine@FreeBSD.org> To: bug-followup@FreeBSD.org, joemann@beefree.free.de Cc: Subject: Re: ports/186982: [PATCH] net/xorp: update to 1.8.5 Date: Wed, 26 Feb 2014 18:57:55 +0100 Hi, There are some problems with your patch: - PORTREVISION=0 can be removed - you can use DISTVERSIONSUFFIX= -src - MAKE_JOBS_SAFE is obsolete - your patch replaces use of OPTIONS with obsolete WITH/WITHOUT - USE_OPENSSL has to stay, some people build base without it - USE_SCONS is deprecated, it should be USES= scons - rc script name is changed to .sh , this is obsolete - should use GROUPS= to create the group instead of a pkg-install/pkg-deinstall script (this was already a problem before) - you can remove the post-install part, it's not necessary with staging - /usr/local seems hardcoded in some patches, this is not pretty Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402261800.s1QI01IF026884>