Date: Fri, 09 Apr 2004 22:59:25 +0900 From: Jun Kuriyama <kuriyama@imgsrc.co.jp> To: Current <freebsd-current@FreeBSD.org> Subject: Clean up libdisk for WARNS=4 Message-ID: <7m4qrtxneq.wl@black.imgsrc.co.jp>
next in thread | raw e-mail | index | archive | help
I did a bad commit for WARNS=4 of libdisk which breaks non-i386 build. I'm trying to solve this in other archs, too. http://www.imgsrc.co.jp/~kuriyama/BSD/libdisk-20040404.diff o Added many __unused's to avoid warnings on all archs. o Added file local struct definition in open_ia64_disk.c to avoid pointer alignment problem. o Renamed some variables to resolve conflicts with other enum constants (same as in i386). o Used uint64_t buffer instead of u_char buffer. This simplifed uint64_t array manipulation in latter of this function. But it looks ugly. o Used ssize_t storage instead of direct comparison of singed/unsigned. I'm not sure all of this is done by good way or not. So I'd like to be reviewed... -- Jun Kuriyama <kuriyama@imgsrc.co.jp> // IMG SRC, Inc. <kuriyama@FreeBSD.org> // FreeBSD Project
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7m4qrtxneq.wl>