Date: Tue, 21 Jan 2003 20:07:01 -0800 From: Peter Wemm <peter@wemm.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Kris Kennaway <kris@obsecurity.org>, hackers@FreeBSD.ORG, Hiten Pandya <hiten@unixdaemons.com> Subject: Re: patch to remove random #define MIN/MAX implementations from around the kernel Message-ID: <20030122040701.37A442A7EA@canning.wemm.org> In-Reply-To: <200301220402.h0M42xBo000193@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon wrote: > > :On Tue, Jan 21, 2003 at 07:25:44PM -0800, Matthew Dillon wrote: > :> This patch is going to go in on the weekend unless someone has any > :> worthwhile nits about it. It was submitted by Hiten Pandya. > : > :> Index: contrib/dev/oltr/if_oltr.c > : > :> Index: contrib/ipfilter/netinet/ip_proxy.c > : > :> Index: netinet6/nd6.c > : > :You shouldn't modify vendor code for minor purposes. > : > :Kris > > The vendor code in question has been modified *extensively* since > it was imported, (and of course I would give Darren a head's up in > regards to ipfilter). Unless you have a more specific reason I don't > really think a general blanket statement is sufficient reason to not > do the commit, at least not in this case. Didn't we explicitly make it like this? ie: you'd be backing out a previous set of intentional commits by doing this... Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030122040701.37A442A7EA>