Date: Wed, 16 Sep 2009 12:10:02 -0400 (EDT) From: Vivek Khera <vivek@khera.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/138883: p5-Net-XMPP registers unnecessary run-dependency Message-ID: <20090916161002.B005AA102D@lorax.kcilink.com> Resent-Message-ID: <200909161620.n8GGK5Y5064362@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 138883 >Category: ports >Synopsis: p5-Net-XMPP registers unnecessary run-dependency >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Sep 16 16:20:05 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Vivek Khera >Release: FreeBSD 7.2-RELEASE-p2 i386 >Organization: >Environment: System: FreeBSD lorax.kcilink.com 7.2-RELEASE-p2 FreeBSD 7.2-RELEASE-p2 #12: Tue Jul 14 11:32:39 EDT 2009 steve@lorax.kcilink.com:/u/lorax1/usr7/obj.i386/u/lorax1/usr7/src/sys/KCI32SMP i386 >Description: The way the net-im/p5-Net-XMPP makefile is written, it registers Module::Build as a runtime dependency, whereas that is only needed during compile time. This patch adjusts the dependency lists so that the run and build dependencies are more correct. >How-To-Repeat: Compare the RUN_DEPENDS lists. In the current port: # make -V BUILD_DEPENDS p5-XML-Stream>=1.22:/usr/ports/textproc/p5-XML-Stream p5-Digest-SHA1>=1.02:/usr/ports/security/p5-Digest-SHA1 /usr/local/lib/perl5/site_perl/5.8.9/Module/Build.pm:/usr/ports/devel/p5-Module-Build /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8 # make -V RUN_DEPENDS p5-XML-Stream>=1.22:/usr/ports/textproc/p5-XML-Stream p5-Digest-SHA1>=1.02:/usr/ports/security/p5-Digest-SHA1 /usr/local/lib/perl5/site_perl/5.8.9/Module/Build.pm:/usr/ports/devel/p5-Module-Build /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8 /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8 In the revised port: # make -V BUILD_DEPENDS p5-XML-Stream>=1.22:/usr/ports/textproc/p5-XML-Stream p5-Digest-SHA1>=1.02:/usr/ports/security/p5-Digest-SHA1 /usr/local/lib/perl5/site_perl/5.8.9/Module/Build.pm:/usr/ports/devel/p5-Module-Build /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8 # make -V RUN_DEPENDS p5-XML-Stream>=1.22:/usr/ports/textproc/p5-XML-Stream p5-Digest-SHA1>=1.02:/usr/ports/security/p5-Digest-SHA1 /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8 >Fix: diff -Nru p5-Net-XMPP.old/Makefile p5-Net-XMPP/Makefile --- p5-Net-XMPP.old/Makefile 2008-01-04 18:48:20.000000000 -0500 +++ p5-Net-XMPP/Makefile 2009-09-16 12:01:54.000000000 -0400 @@ -14,9 +14,10 @@ MAINTAINER= perl@FreeBSD.org COMMENT= Net::XMPP provides Perl Developer access to the XMPP protocol -BUILD_DEPENDS= p5-XML-Stream>=1.22:${PORTSDIR}/textproc/p5-XML-Stream \ +BUILD_DEPENDS+= p5-XML-Stream>=1.22:${PORTSDIR}/textproc/p5-XML-Stream \ + p5-Digest-SHA1>=1.02:${PORTSDIR}/security/p5-Digest-SHA1 +RUN_DEPENDS+= p5-XML-Stream>=1.22:${PORTSDIR}/textproc/p5-XML-Stream \ p5-Digest-SHA1>=1.02:${PORTSDIR}/security/p5-Digest-SHA1 -RUN_DEPENDS= ${BUILD_DEPENDS} USE_PERL5= 5.8.0+ # Require perl 5.8.x due to XML::Stream PERL_MODBUILD= yes >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090916161002.B005AA102D>