Date: Thu, 1 May 2003 04:12:10 -0700 From: Luigi Rizzo <rizzo@icir.org> To: Mike Silbersack <silby@silby.com> Cc: freebsd-net@freebsd.org Subject: Re: Review needed: Mbuf double-free detection patch Message-ID: <20030501041210.A3514@xorpc.icir.org> In-Reply-To: <20030430142532.F3741@odysseus.silby.com>; from silby@silby.com on Wed, Apr 30, 2003 at 02:35:23PM -0500 References: <20030430142532.F3741@odysseus.silby.com>
next in thread | previous in thread | raw e-mail | index | archive | help
as Bosko noticed, it would be a good idea to make the change to subr_mbuf.c conditionally compiled under DIAGNOSTIC or INVARIANTS or the like. I was actually wondering if you have caught already any bug with this code enabled. [on a side note, it is a bit depressing to see the same code replicated twice, in m_free() and m_freem(). Couldn't one try to make m_freem() just call m_free() in a loop and save some code bloat ? I doubt the extra function call would harm performance too much.] cheers luigi On Wed, Apr 30, 2003 at 02:35:23PM -0500, Mike Silbersack wrote: > > I'd be interested in comments on the attached patch from anyone who's been > doing work with network drivers & such. All it does is add a M_FREELIST ...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030501041210.A3514>