Date: Fri, 20 Dec 2013 09:36:42 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Roger Pau Monne <roger.pau@citrix.com> Cc: xen-devel@lists.xen.org, julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, gibbs@freebsd.org Subject: Re: [PATCH v7 01/19] xen: add PV/PVH kernel entry point Message-ID: <20131220073642.GP59496@kib.kiev.ua> In-Reply-To: <1387479296-33389-2-git-send-email-roger.pau@citrix.com> References: <1387479296-33389-1-git-send-email-roger.pau@citrix.com> <1387479296-33389-2-git-send-email-roger.pau@citrix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--/NOItKPPfAGZtKZd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thank you for doing the split. On Thu, Dec 19, 2013 at 07:54:38PM +0100, Roger Pau Monne wrote: > Add the PV/PVH entry point and the low level functions for PVH > initialization. > --- > sys/amd64/amd64/locore.S | 53 +++++++++++++++++++++++++++++++ > sys/amd64/amd64/machdep.c | 72 ++++++++++++++++++++++++++++++++++++++++++ > sys/amd64/include/asmacros.h | 26 +++++++++++++++ The changes to the three files above all protected by #ifdef XENHVM. IMO it is more logical to move the code into xen-specific files. The support would be localized and somewhat postpone morphing the sys/amd64 into the maze of #ifdefs, which is the sys/i386 already. --/NOItKPPfAGZtKZd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSs/OJAAoJEJDCuSvBvK1B+2cQAJKoJaZryNNJuOiN67ocHEHy R3PyKtisqo0b2ABgobYhfv1wxRXfr3fhW2Hqzd9GJfEcg/7hV9KSjilBIDnWrbii 720/VuGFh3vQRIWSu6WqylVPxkPkNrEW6pbzcja/FuxYeyheFanxMT5Fu3/uWxGG CadiT8VErkh6Z4HZnOi0goURiXkzpvU4kc/q0MeeUuPWd1KEA+OPxBmcaOz9+lfi FYmRJ0u3BqmPHvbXQpWMeaTAOS5MdhJkp3v5Q2tFlqNHXNYesm3JpwdaiceHAzUG gfpvBKxxVGw1TP3TcBuxN3v8NMlzsFdaO0EfNXL2jR12x21rs67t4LZxWpsF/5yr 6pAp+1DHWsY4FSKTAvRXI5XHlrA1Zb8IP/egIrtEVC0FoCKdgjgzS1mr3EOIYp4t 126R5fvc7TIcC1yZF6YfdlYrmT6RLducDYptnhibQ9DOixYV1iwiBpCGK5FX5etp Bg8i5SBdxDcqPYQvbg7PH+BaWct1K+Y48a/CDAb9/ACtwk8G+OHHmTEHLpx9NEs5 D38iuAi+bdRPjBVYW8n6CFGXgvSsLzLoYPUshPo9BZt2uB0opo5Og4nnoigSxk/L /hL+SLz3gaYmVNSUGu15UkTRLDuep5Sq4vHba09jmoptLoItxAPA3x4Drt9Je7zK CA4TxTE0C2l+BKLpYjuV =bBCJ -----END PGP SIGNATURE----- --/NOItKPPfAGZtKZd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131220073642.GP59496>