Date: Tue, 19 May 2009 13:49:41 +0900 From: Weongyo Jeong <weongyo.jeong@gmail.com> To: Lucius Windschuh <lwindschuh@googlemail.com> Cc: freebsd-current@freebsd.org, Hans Petter Selasky <hselasky@c2i.net> Subject: Re: Panics and potential memory corruption when pulling out a uath device Message-ID: <20090519044941.GC42412@weongyo.cdnetworks.kr> In-Reply-To: <90a5caac0905181508m7024377as8d70c89694a21e26@mail.gmail.com> References: <90a5caac0905171354k6e7c008eye18bd69aa543eaa6@mail.gmail.com> <200905181050.03154.hselasky@c2i.net> <90a5caac0905181508m7024377as8d70c89694a21e26@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 19, 2009 at 12:08:45AM +0200, Lucius Windschuh wrote: > 2009/5/18 Hans Petter Selasky <hselasky@c2i.net>: > > Regarding the first panic, there seems to be a detach race in both upgt and > > uath, which is not USB related. Try this patch: > > > > http://perforce.freebsd.org/chv.cgi?CH=162250 > > This fixes not only the first panic. > I can't provoke any panic by pulling out the active device. Thanks. Could you please test with this patch that is slightly different with Hans's patch? It try to unsetup after stopping the device. If no problems I'd commit it. regards, Weongyo Jeong --BXVAT5kNtrzKuDFl Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="patch_uath_20090519.diff" Index: if_uath.c =================================================================== --- if_uath.c (revision 192368) +++ if_uath.c (working copy) @@ -517,12 +517,12 @@ sc->sc_flags |= UATH_FLAG_INVALID; uath_stop(ifp); - ieee80211_ifdetach(ic); callout_drain(&sc->stat_ch); callout_drain(&sc->watchdog_ch); usb2_transfer_unsetup(sc->sc_xfer, UATH_N_XFERS); + ieee80211_ifdetach(ic); /* free buffers */ UATH_LOCK(sc); --BXVAT5kNtrzKuDFl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090519044941.GC42412>