Date: Wed, 23 Jun 2010 17:54:25 +0300 From: Alexander Motin <mav@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-arch@freebsd.org Subject: Re: "stray irqX" or "irqX: stray" Message-ID: <4C222021.7040707@FreeBSD.org> In-Reply-To: <201006230951.16046.jhb@freebsd.org> References: <4C21AE15.6030109@FreeBSD.org> <201006230951.16046.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > On Wednesday 23 June 2010 2:47:49 am Alexander Motin wrote: >> Now we use different format for stray irq counters names (can be better >> seen at `vmstat -ia`). Considering stray is a kind of special case (I >> know no other cases using additional counters for interrupt source), I >> still think it can be made somewhat more unified. I think we could >> change "stray irqX" format to "irqX: stray". This format IMHO better >> fits into existing naming scheme of "source: driver". > > I actually think it is more of a feature that they don't match since they > should never occur. If one does occur it should be noticeable and not "blend > in" with other interrupts. That is an argument. But to be noticed it is also logged to console and messages. Unified formats instead could IMHO simplify it's processing. We have a very much different formats there now, especially if compare different archs. Problem is that, for example, `systat -vm` tries to format that string to fit it into available 10 characters. I can't say that I like this idea, but it looks even more tricky, when format is not unified. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C222021.7040707>