Date: Thu, 25 Oct 2001 18:14:15 +0200 From: dirk.meyer@dinoex.sub.org (Dirk Meyer) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, nectar@nectar.com Subject: Re: cvs commit: ports/security/openssh Makefile ports/security/openssh/files patch-coredump ports/security/openssh-portable Makefile ports/security/openssh-portable/files patch-coredump Message-ID: <f6PykbZKRw@dmeyer.dinoex.sub.org> References: <200110240716.f9O7GnQ17535@freefall.freebsd.org> <200110240716.f9O7GnQ17535@freefall.freebsd.org> <20011025070926.A73086@madman.nectar.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Jacques A. Vidrine wrote: > Please do not use more than one patch file per source file. Now both > `patch-session.c' and `patch-coredump' modify `session.c'. > > Also, do you have more information on the problem that is supposedly > solved by this patch? The patch simply initializes `env' to NULL. > However, `env' is not used before being initialized that I can see. > Did I miss something? http://www.FreeBSD.org/cgi/search.cgi?words=ht3BBA7E1E.931F087D%40prism.gatech.edu&max=25&sort=date&index=recent&source=freebsd-stable The patch Ryan suggested was confirmed in the base system. But I failed to see that it can't fail on opennssh 2.9.9, where the handling was totally rewritten inside. kind regards Dirk - Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany ryanb@goddamnbastard.org (ryan beasley) wrote: > Sorry for replying to myself, but I drafted this little "patch" that > should take care of the segfault in session.c. After thinking about > this for a bit, it probably should've been _really_ obvious to me > after the first lookover ... > > --- src/crypto/openssh/session.c.orig Wed Oct 24 00:35:57 2001 > +++ src/crypto/openssh/session.c Wed Oct 24 00:36:26 2001 > @@ -1003,7 +1003,7 @@ > char cmd[1024]; > FILE *f =3D NULL; > u_int envsize, i; > - char **env; > + char **env =3D NULL; > extern char **environ; > struct stat st; > char *argv[10]; > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f6PykbZKRw>