Date: Sat, 02 Dec 2000 17:34:02 -0800 From: David Greenman <dg@root.com> To: John Baldwin <jhb@FreeBSD.org> Cc: Bosko Milekic <bmilekic@FreeBSD.org>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c Message-ID: <200012030134.RAA16643@implode.root.com> In-Reply-To: Your message of "Sat, 02 Dec 2000 17:01:05 PST." <XFMail.001202170105.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>On 02-Dec-2000 Bosko Milekic wrote: >> bmilekic 2000/12/01 16:40:57 PST >> >> Modified files: >> sys/kern uipc_syscalls.c >> Log: >> Make sure to free the sf_buf if we've allocated it but fail to allocate >> an mbuf (ENOBUFS) before returning so that we don't leak sf_bufs in >> the case where we're out of mbufs. >> >> Submitted by: David Greenman (dg) > >Should the second argument be NULL rather than PAGE_SIZE to sf_buf_free()? > >../../kern/uipc_syscalls.c: In function `sendfile': >../../kern/uipc_syscalls.c:1708: warning: passing arg 2 of `sf_buf_free' makes >pointer from integer without a cast > >>From my reading, the args parameter isn't even used by sf_buf_free()... In -current it should be NULL, in -stable it should be PAGE_SIZE. In both branches the argument is ignored. The patch I supplied was for -stable. -DG David Greenman Co-founder, The FreeBSD Project - http://www.freebsd.org President, TeraSolutions, Inc. - http://www.terasolutions.com Pave the road of life with opportunities. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012030134.RAA16643>