Date: Sun, 25 May 2014 09:12:35 +0200 From: John Marino <freebsd.contact@marino.st> To: freebsd-ports@freebsd.org Subject: Re: Is staging a port really this simple? Message-ID: <538197E3.1070609@marino.st> In-Reply-To: <CADtCJqoTpSB0E9uN8Y6CkZm_8wjU0b5Pc50vT=pB-bHjZmGpeQ@mail.gmail.com> References: <524CE820.5060003@missouri.edu> <20131003061511.GF85314@ithaqua.etoilebsd.net> <538179d9.ERL3ZKEnk4pQKKib%perryh@pluto.rain.com> <CADtCJqoTpSB0E9uN8Y6CkZm_8wjU0b5Pc50vT=pB-bHjZmGpeQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/25/2014 09:09, Zsolt Udvari wrote:
> 2014-05-25 7:04 GMT+02:00 Perry Hutchison <perryh@pluto.rain.com>:
>> post-install:
>> - @[ -f ${PREFIX}/etc/diskcheckd.conf ] \
>> - || ${CP} -p ${PREFIX}/etc/diskcheckd.conf.sample \
>> - ${PREFIX}/etc/diskcheckd.conf
>> + @[ -f ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf ] \
>> + || ${CP} -p ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf.sample \
>> + ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf
> Your condition is unneeded.
> You don't need check the existence of
> ${STAGEDIR}${PREFIX}/etc/distcheckd.conf because you'll copy it, the
> ${STAGEDIR} are empty!!!!
> The reason of "old" check was: shouldn't overwrite the existing
> distcheckd.conf (in system, not STAGEDIR). These checks are
> unnecessary, the 'pkg' does it.
>
no, the @sample keyword in pkg-plist does that (replacing other lines
there). pkg doesn't do this by itself, it needs to be told.
John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?538197E3.1070609>