Date: Tue, 14 Feb 2006 21:55:15 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netncp ncp_conn.c Message-ID: <200602142155.k1ELtFFb043006@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2006-02-14 21:55:15 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_6)
sys/netncp ncp_conn.c
Log:
Merge ncp_conn.c:1.28 from HEAD to RELENG_6:
In ncp_sysctl_connstat(), the SLIST_FOREACH() logic to check 'error'
resulted in deadcode, as 'error' could never be 0. What this logic
was originally meant to handle is not clear -- it's been this way
(broken) since at least RELENG_4.
Found with: Coverity Prevent(tm)
Approved by: re (scottl)
Revision Changes Path
1.26.2.1 +1 -7 src/sys/netncp/ncp_conn.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602142155.k1ELtFFb043006>