Date: Mon, 3 Feb 2014 10:33:23 +0000 From: David Chisnall <theraven@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r341510 - head/lang/libobjc2 Message-ID: <FC14339A-AC0E-47B5-A821-42398E154889@FreeBSD.org> In-Reply-To: <20140203111542.426f69be@kalimero.tijl.coosemans.org> References: <201401280813.s0S8DcHf067201@svn.freebsd.org> <20140203111542.426f69be@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 Feb 2014, at 10:15, Tijl Coosemans <tijl@FreeBSD.org> wrote:
>=20
> The port is currently broken. By removing the bsd.port.pre.mk include
> -DCMAKE_C_COMPILER:STRING=3D"${CC}" in Uses/cmake.mk now comes after =
the
> -DCMAKE_C_COMPILER=3D${CLANG} here so it doesn't have any effect. =
Same for
> CXX.
>=20
> Instead of putting .include <bsd.port.pre.mk> back, maybe the port =
should
> define CC=3D${CLANG} CXX=3D${CLANGXX} and remove the second CMAKE_ARGS =
line?
Indeed. This is currently a bit of a hack. Ideally, we should remove =
that ugliness and have a USES=3Dcompiler:objc (ideally objc-1.7 to =
specify the runtime ABI version), which would give us clang from either =
ports or base depending on whether there is one in base and what its =
version is.
David
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FC14339A-AC0E-47B5-A821-42398E154889>