Date: Thu, 29 Jan 2004 16:32:08 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Guido van Rooij <guido@gvr.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sbin/mount mount.c Message-ID: <20040129143208.GH19899@FreeBSD.org.ua> In-Reply-To: <20040129142659.GA23750@gvr.gvr.org> References: <200401291316.i0TDGpbj052050@repoman.freebsd.org> <20040129132732.GB19899@FreeBSD.org.ua> <xzpu12e7sr7.fsf@dwp.des.no> <20040129140955.GX47004@submonkey.net> <20040129142659.GA23750@gvr.gvr.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Az4VpBrmI9+OyhK/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Jan 29, 2004 at 03:26:59PM +0100, Guido van Rooij wrote:
> On Thu, Jan 29, 2004 at 02:09:55PM +0000, Ceri Davies wrote:
> > On Thu, Jan 29, 2004 at 03:07:40PM +0100, Dag-Erling Sm?rgrav wrote:
> > > Ruslan Ermilov <ru@FreeBSD.org> writes:
> > > > Did you mean -u here, because -a is not listed as allowed
> > > > in combination with the -o option?
> > >=20
> > > no, his patch makes
> > >=20
> > > # mount -u -o fstab -a -t ufs
> > >=20
> > > work as expected (i.e. restore the fstab flags on all ufs filesystems)
> > >=20
> > > previously,
> > >=20
> > > # mount -u -o fstab /specific/mount/point
> > >=20
> > > would work, but the -a version wouldn't.
> >=20
> > The manpage and usage bits should be updated to reflect this. I'm not
> > sure, but I think that's what Ruslan was getting at.
> >=20
>=20
> I don't get it..it is not specifically mentioned as forbidden. So
> it should work.=20
> What Ruslan meant (at least that is how I see it) is that
> -o fstab is only mentioned in combination with -u. That is correct.
> It still works with -a (without the -u), but specifying it is pointless
> as its net effect is nill. So I would not update the manual page.
>=20
usage: mount [-dfpruvw] [-o options] [-t ufs | external_type] special node
mount [-adfpruvw] [ -F fstab] [-t ufs | external_type]
mount [-dfpruvw] special | node
Can you see the -a option on the first line with -o? I can't.
The fix is to add -a as allowed option to the first line of
program's usage() and manpage's SYNOPSIS.
Cheers,
--=20
Ruslan Ermilov
FreeBSD committer
ru@FreeBSD.org
--Az4VpBrmI9+OyhK/
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAGRlnUkv4P6juNwoRAmspAKCCWM7tjxrutpqyU12gQlkuw6pMmwCfeOvm
UHqTxP4OuS2yj4ED1tRSmZw=
=4wVc
-----END PGP SIGNATURE-----
--Az4VpBrmI9+OyhK/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040129143208.GH19899>