Date: Tue, 19 Apr 2016 06:26:08 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Steven Hartland <steven.hartland@multiplay.co.uk>, araujo@FreeBSD.org Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r298244 - head/sbin/dumpon Message-ID: <fe60349c-ae57-e727-7de1-1e919da7bd06@FreeBSD.org> In-Reply-To: <5715D615.8020806@multiplay.co.uk> References: <201604190428.u3J4SP2w044552@repo.freebsd.org> <53a3202e-c144-b7d0-02f1-a7f4364d594e@FreeBSD.org> <CAOfEmZit0sVmE4Osp47H-E1teSmyHFKZEkb00qT-XnTJFmMUug@mail.gmail.com> <5715D615.8020806@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/19/16 01:54, Steven Hartland wrote: > > On 19/04/2016 06:01, Marcelo Araujo wrote: >> >> >> 2016-04-19 12:58 GMT+08:00 Pedro Giffuni <pfg@freebsd.org >> <mailto:pfg@freebsd.org>>: >> >> >> >> On 04/18/16 23:28, Marcelo Araujo wrote: >> >> Author: araujo >> Date: Tue Apr 19 04:28:25 2016 >> New Revision: 298244 >> URL: https://svnweb.freebsd.org/changeset/base/298244 >> >> Log: >> Use nitems() instead of sizeof(name) / sizeof(*name). >> >> MFC after: 2 weeks. >> >> >> FWIW, while I see why it makes sense to make these cosmetic >> changes, it's probably too much to MFC them. >> >> At least I have no plans to merge the ones I've made since >> they are non-functional. >> >> Pedro. >> >> >> I was thinking to MFC it at once(less work)! As now I'm >> checking/committing one by one. >> > Also not MFC'ing is likely to make it much harder to MFC other > functional changes in the same area, so if they are easy then I'd say do > it :) > That's fine. It's a personal choice. I just don't think many people will be reading the code for dumpon, and if they do they should probably read current anyways ;). Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fe60349c-ae57-e727-7de1-1e919da7bd06>