Date: Mon, 08 Feb 2016 22:27:06 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 207031] ixv driver accesses offsets beyond the VF's PCI BAR Message-ID: <bug-207031-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207031 Bug ID: 207031 Summary: ixv driver accesses offsets beyond the VF's PCI BAR Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: jlott@averesystems.com Created attachment 166757 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D166757&action= =3Dedit Proposed patch The ixv driver incorrectly accesses the following non-VF registers: IXGBE_E= RRBC and IXGBE_RXCSUM. The offset of these registers is actually larger than the VF's bar size, so it ends up overflowing and accessing the next BAR instead. This could cause issues, but by happenstance it ends up writing to an unused portion of the MSI-X table BAR of the VF, which seems to have no ill effect. Could cause problems if the pci layout were changed/different and definitely appears to be incorrect. I attached a patch that removes these accesses. Removing the IXGBE_ERRBC ac= cess should be no problem. For IXGBE_RXCSUM I'm less sure, but I don't see any equivalent register to set in the VF register specification. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207031-8>