Date: Fri, 12 Jul 2002 16:47:01 -0700 (PDT) From: Peter Wemm <peter@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 14166 for review Message-ID: <200207122347.g6CNl1UD029845@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14166 Change 14166 by peter@peter_xeon on 2002/07/12 16:46:53 add two more lockchecks. Unfortunately this panics, because vm_page_free_toq() removes pages from the free queue without holding the free queue locked. Affected files ... .. //depot/projects/pmap/sys/vm/vm_pageq.c#6 edit Differences ... ==== //depot/projects/pmap/sys/vm/vm_pageq.c#6 (text+ko) ==== @@ -106,6 +106,7 @@ { struct vpgqueues *vpq; + LOCKCHECK(queue); vpq = &vm_page_queues[queue]; m->queue = queue; TAILQ_INSERT_TAIL(&vpq->pl, m, pageq); @@ -147,7 +148,9 @@ { int queue = m->queue; struct vpgqueues *pq; + if (queue != PQ_NONE) { + LOCKCHECK(PQ_FREE); pq = &vm_page_queues[queue]; m->queue = PQ_NONE; TAILQ_REMOVE(&pq->pl, m, pageq); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207122347.g6CNl1UD029845>