Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 May 2009 13:07:15 +0200
From:      =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To:        rea-fbsd@codelabs.ru
Cc:        freebsd-hackers@freebsd.org, Jakub Lach <jakub_lach@mailplus.pl>
Subject:   Re: FYI Lighttpd 1.4.23 /kernel (trailing '/' on regular file symlink) vulnerability
Message-ID:  <86vdnmiz30.fsf@ds4.des.no>
In-Reply-To: <0vGjPHEq7MqxjtFmBufY%2BmBxlR4@7oUjtCwN654QcDr16CH%2BkAk8bJg> (Eygene Ryabinkin's message of "Wed, 27 May 2009 13:52:21 %2B0400")
References:  <23727599.post@talk.nabble.com> <86prdvipwe.fsf@ds4.des.no> <0vGjPHEq7MqxjtFmBufY%2BmBxlR4@7oUjtCwN654QcDr16CH%2BkAk8bJg>

next in thread | previous in thread | raw e-mail | index | archive | help
Eygene Ryabinkin <rea-fbsd@codelabs.ru> writes:
> May be the attached patch will fix the thing?=20

I'm not entirely convinced.  Try the regression test I wrote
(head/tools/regression/vfs/trailing_slash.t)

> It adds an additional flag, but this was the only thing I was able to
> invent to avoid ABI breakage.

The flag is a good idea, but I think the correct place to handle this is
in namei(), around line 290 (don't be fooled by the comment on line 270;
the code inside the if statement is for the *non*-symlink case).

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86vdnmiz30.fsf>