Date: Wed, 9 Mar 2005 00:39:55 -0500 From: Brian Fundakowski Feldman <green@freebsd.org> To: Maxim Sobolev <sobomax@portaone.com> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c Message-ID: <20050309053955.GB993@green.homeunix.org> In-Reply-To: <422E3EC1.4050402@portaone.com> References: <200503070726.j277Qhp5059059@repoman.freebsd.org> <20050308012939.GP11079@elvis.mu.org> <422DCF52.6080109@portaone.com> <20050308210414.GU11079@elvis.mu.org> <20050308232209.GX11079@elvis.mu.org> <422E3EC1.4050402@portaone.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 09, 2005 at 02:09:37AM +0200, Maxim Sobolev wrote: > Looks fine, though it's hard for me to comment about adding yet another > flag that not present in standards. However, in my pretty > unauthoritative opinion, since Linux has it, while many people and ISVs > out there use it as a sort of reference when developing free software, > it will probably make sense to support it as well, especially > considering that it's pretty easy to do. > > In any case, since it's definitelty an API/ABI change (programs that use > MSG_NOSIGNAL won't compile on older systems, while binary programs that > use it may not work correctly on older systems) it also warrants > __FreeBSD_version bump and proper documentation in the Porter's > Handbook. Also the ABI argument probably puts MFC out of question. > > Thanks! Do you need to bump it when #ifdef can already serve that purpose? -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050309053955.GB993>