Date: Thu, 10 Dec 2015 18:46:07 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Hajimu UMEMOTO <ume@freebsd.org> Cc: Bruce Evans <brde@optusnet.com.au>, Eric van Gyzen <vangyzen@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291994 - head/include Message-ID: <20151210183005.M1400@besplex.bde.org> In-Reply-To: <ygefuzb4lpb.wl-ume@FreeBSD.org> References: <201512081609.tB8G9mfd053070@repo.freebsd.org> <yge1tawwei9.wl-ume@FreeBSD.org> <20151209173008.A828@besplex.bde.org> <ygefuzb4lpb.wl-ume@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 10 Dec 2015, Hajimu UMEMOTO wrote: >>>>>> On Wed, 9 Dec 2015 18:19:16 +1100 (EST) >>>>>> Bruce Evans <brde@optusnet.com.au> said: > > brde> resolv.h already had massinve namespace pollution and style bugs in > brde> its includes. One more include of a header that is relatively clean > brde> since it is tiny and was designed for minimising namespace pollution > brde> makes little difference. > > I understood. Thank you for your detailed explanation. > However, I realized that r289315 changed the size of struct > __res_state. It broke binary backward compatibility. I think we > still need to revert its change in struct __res_state and move them > into struct __res_state_ext. I see. Most of the pollution in resolv.h dates from 1993, so is hard to fix now. It was not in 4.4BSD. In 4.4BSD, <stdio.h> was a prerequisite, and undocumented APIs like fp_query() that used FILE were named with leading underscores. The ABI changes in __res_state are mostly newer than than 1993. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151210183005.M1400>