Date: Wed, 29 Mar 2000 19:14:20 -0800 From: Alfred Perlstein <bright@wintelcom.net> To: Giorgos Keramidas <keramida@ceid.upatras.gr> Cc: questions@FreeBSD.ORG Subject: Re: CVS logs question Message-ID: <20000329191420.R21029@fw.wintelcom.net> In-Reply-To: <20000329182846.A12501@hades.hell.gr>; from keramida@ceid.upatras.gr on Wed, Mar 29, 2000 at 06:28:46PM %2B0300 References: <20000329182846.A12501@hades.hell.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
* Giorgos Keramidas <keramida@ceid.upatras.gr> [000329 17:51] wrote: > I was browsing through the CVS logs this afternoon, and found the > following in cp/utils.c,v: > > revision 1.21 > date: 1998/11/18 11:47:45; author: bde; state: Exp; lines: +2 -2 > branches: 1.21.2; > Don't use mmap() for non-regular files, since st_size is only meaningful > for regular files. This fixes recent breakage of cp'ing from /dev/zero. > /dev/zero doesn't support mmap(), but the device driver mmap routines are > not called for mapping 0 bytes, so the error was not detected. mmap() > can't even be used for cp'ing special files that support mmap(), since > there is general way to determine the file size. > > The last sentence is obviously missing a negation; I would guess it was > meant to be '..since there is no general way to determine the file size.' > ^^ > > However, I was wandering are we to correct such things in the logs, or > this seems like a useless thing to do? Generally people will do a "null commit" to correct a log entry, but generally only if detected right away, sometimes too much time has passed and we just live with iti (or at least that's my impression of how it works). -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-questions" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000329191420.R21029>