Date: Mon, 4 Mar 2013 14:23:28 +0900 From: YongHyeon PYUN <pyunyh@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: current@freebsd.org Subject: Re: ale(4) cannot negotiate as GigE Message-ID: <20130304052328.GA1445@michelle.cdnetworks.com> In-Reply-To: <20130304024631.GA78040@FreeBSD.org> References: <20130221124344.GA93056@FreeBSD.org> <20130222011308.GA3259@michelle.cdnetworks.com> <20130222015607.GC66767@FreeBSD.org> <20130225082344.GC1426@michelle.cdnetworks.com> <20130303095330.GA57026@FreeBSD.org> <20130303120010.GA84560@FreeBSD.org> <20130304005044.GA4589@michelle.cdnetworks.com> <20130304015344.GA62059@FreeBSD.org> <20130304021059.GC4589@michelle.cdnetworks.com> <20130304024631.GA78040@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--/9DWx/yDrRhgMJTb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Mon, Mar 04, 2013 at 02:46:31AM +0000, Alexey Dokuchaev wrote:
> On Mon, Mar 04, 2013 at 11:10:59AM +0900, YongHyeon PYUN wrote:
> > On Mon, Mar 04, 2013 at 01:53:44AM +0000, Alexey Dokuchaev wrote:
> > > Yes, it did help. With 2000us delays (I didn't revert them [...]
> >
> > Great! But it seems 2ms delays is too much. Could you revert the change
> > (2000us delays) and try it again?
>
> Reverting if_ale.c, making kernel, and reboot gave me 100baseTX again; :-(
> second reboot (with the same kernel) did not help. Bumping delays to 2ms
> (just to make sure) restored GigE mode upon 1st reboot after "make kernel".
>
Ok, here is final diff which combines two things you've tested.
So revert any changes before applying it.
Let me know how it goes on your box.
> ./danfe
--/9DWx/yDrRhgMJTb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ale.pr.diff3"
Index: sys/dev/ale/if_ale.c
===================================================================
--- sys/dev/ale/if_ale.c (revision 247382)
+++ sys/dev/ale/if_ale.c (working copy)
@@ -406,11 +406,11 @@ ale_phy_reset(struct ale_softc *sc)
CSR_WRITE_2(sc, ALE_GPHY_CTRL,
GPHY_CTRL_HIB_EN | GPHY_CTRL_HIB_PULSE | GPHY_CTRL_SEL_ANA_RESET |
GPHY_CTRL_PHY_PLL_ON);
- DELAY(1000);
+ DELAY(2000);
CSR_WRITE_2(sc, ALE_GPHY_CTRL,
GPHY_CTRL_EXT_RESET | GPHY_CTRL_HIB_EN | GPHY_CTRL_HIB_PULSE |
GPHY_CTRL_SEL_ANA_RESET | GPHY_CTRL_PHY_PLL_ON);
- DELAY(1000);
+ DELAY(2000);
#define ATPHY_DBG_ADDR 0x1D
#define ATPHY_DBG_DATA 0x1E
@@ -635,7 +635,7 @@ ale_attach(device_t dev)
/* Set up MII bus. */
error = mii_attach(dev, &sc->ale_miibus, ifp, ale_mediachange,
ale_mediastatus, BMSR_DEFCAPMASK, sc->ale_phyaddr, MII_OFFSET_ANY,
- MIIF_DOPAUSE);
+ MIIF_DOPAUSE | MIIF_MACPRIV0);
if (error != 0) {
device_printf(dev, "attaching PHYs failed\n");
goto fail;
Index: sys/dev/mii/atphy.c
===================================================================
--- sys/dev/mii/atphy.c (revision 247382)
+++ sys/dev/mii/atphy.c (working copy)
@@ -100,8 +100,14 @@ atphy_probe(device_t dev)
static int
atphy_attach(device_t dev)
{
+ struct mii_attach_args *ma;
+ u_int flags;
- mii_phy_dev_attach(dev, MIIF_NOMANPAUSE, &atphy_funcs, 1);
+ ma = device_get_ivars(dev);
+ flags = MIIF_NOMANPAUSE;
+ if ((miibus_get_flags(dev) & MIIF_MACPRIV0) != 0)
+ flags |= MIIF_PHYPRIV0;
+ mii_phy_dev_attach(dev, flags, &atphy_funcs, 1);
return (0);
}
@@ -287,9 +293,11 @@ atphy_reset(struct mii_softc *sc)
uint32_t reg;
int i;
- /* Take PHY out of power down mode. */
- PHY_WRITE(sc, 29, 0x29);
- PHY_WRITE(sc, 30, 0);
+ if ((sc->mii_flags & MIIF_PHYPRIV0) != 0) {
+ /* Take PHY out of power down mode. */
+ PHY_WRITE(sc, 29, 0x29);
+ PHY_WRITE(sc, 30, 0);
+ }
reg = PHY_READ(sc, ATPHY_SCR);
/* Enable automatic crossover. */
--/9DWx/yDrRhgMJTb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130304052328.GA1445>