Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Mar 2008 19:49:11 GMT
From:      "Randall R. Stewart" <rrs@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 137017 for review
Message-ID:  <200803061949.m26JnBw6034694@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=137017

Change 137017 by rrs@rrs-mips2-jnpr on 2008/03/06 19:48:17

	AST's should not be done in trap, the exception code
	       does this.

Affected files ...

.. //depot/projects/mips2-jnpr/src/sys/mips/mips/trap.c#15 edit

Differences ...

==== //depot/projects/mips2-jnpr/src/sys/mips/mips/trap.c#15 (text+ko) ====

@@ -260,7 +260,7 @@
  * kdbpeekD(addr) - skip one word starting at 'addr', then read the second word
  */
 #define	kdbpeekD(addr)	kdbpeek(((int *)(addr)) + 1)
-
+int rrs_debug = 0;
 
 /*
  * MIPS load/store access type
@@ -838,9 +838,6 @@
 			PTRACESTOP_SC(p, td, S_PT_SCX);
 
 			mtx_assert(&Giant, MA_NOTOWNED);
-			if (curthread->td_flags & (TDF_ASTPENDING | TDF_NEEDRESCHED)) {
-				ast(trapframe);
-			}
 			return (trapframe->pc);
 		}
 
@@ -1029,9 +1026,9 @@
 			printf("kernel mode)\n");
 
 #ifdef TRAP_DEBUG
-		printf("badvaddr = %p, pc = %p, ra = %p, sr = 0x%x\n",
-		    trapframe->badvaddr, trapframe->pc, trapframe->ra,
-		    trapframe->sr);
+		printf("badvaddr = %x, pc = %x, ra = %x, sr = 0x%x\n",
+		       trapframe->badvaddr, trapframe->pc, trapframe->ra,
+		       trapframe->sr);
 #endif
 
 #ifdef KDB
@@ -1057,9 +1054,6 @@
 	 */
 	userret(td, trapframe);
 	mtx_assert(&Giant, MA_NOTOWNED);
-	if (curthread->td_flags & (TDF_ASTPENDING | TDF_NEEDRESCHED)) {
-		ast(trapframe);
-	}
 	return (trapframe->pc);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803061949.m26JnBw6034694>