Date: Sun, 03 Feb 2013 12:32:59 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: freebsd-hackers@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: scheduler->swapper, SI_SUB_RUN_SCHEDULER->SI_SUB_LAST Message-ID: <510E3CDB.2070803@FreeBSD.org> In-Reply-To: <20130202145013.GV2522@kib.kiev.ua> References: <510CFD90.9000304@FreeBSD.org> <20130202145013.GV2522@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
on 02/02/2013 16:50 Konstantin Belousov said the following: > On Sat, Feb 02, 2013 at 01:50:40PM +0200, Andriy Gapon wrote: >> >> I would like to propose the following mostly cosmetic change: >> http://people.freebsd.org/~avg/scheduler-swapper.diff >> >> This is something that bit me early in my FreeBSD days, so I am kind of obsessed >> with it. >> The current naming is confusing/misleading indeed. >> And magic properties of SI_SUB_RUN_SCHEDULER:SI_ORDER_LAST is a "hidden gem". > > You may remove the Giant unlock from the scheduler()/swapper() as well > then, doing it before the swapper() call in the mi_startup(). > > Note that the wait chain for the idle swapper is still called "sched". Thank you for the review. I am fixing both issues. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?510E3CDB.2070803>