Date: Tue, 21 Jan 2003 17:29:47 -0800 (PST) From: Nate Lawson <nate@root.org> To: Bruce Evans <bde@zeta.org.au> Cc: Alfred Perlstein <alfred@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.c src/sys/alpha/osf1 imgact_osf1.c osf1_misc.c src/sys/cam cam_periph.c cam_sim.c cam_xpt.c src/sys/cam/scsi scsi_cd.c scsi_ch.c scsi Message-ID: <Pine.BSF.4.21.0301211726290.66961-100000@root.org> In-Reply-To: <20030122100003.K30758-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 22 Jan 2003, Bruce Evans wrote: > > On Tue, 21 Jan 2003, Alfred Perlstein wrote: > > > Log: > > > Remove M_TRYWAIT/M_WAITOK/M_WAIT. Callers should use 0. > > > Merge M_NOWAIT/M_DONTWAIT into a single flag M_NOWAIT. > > Robert Watson wrote: > > Hmm. I guess I missed the discussion; I'm a bit behind on mailing lists. > > To improve code portability and careful thinking by developers, what I'd > > like to see is something more like the following: M_WAITOK, which > > explicitly requests sleeping indefinitely, M_NOWAIT, which explicitly > > requests no sleeping. Rather than a "default" value, a > > That's exactly what M_WAITOK was supposed to do. Developers just had to > think about it since it wasn't really a flag so it was not easy to check > automatically. I like Robert's approach -- keep the flags as they were before but give M_WAITOK a value other than 0 and deprecate passing in 0 as an arg. This change only would affect binary kld compat and if 0 only generated a printf warning (one-shot) but still meant M_WAITOK for a little while, that would ease the migration. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0301211726290.66961-100000>