Date: Thu, 31 Jul 2008 21:50:03 GMT From: Wooseog Choi <ben_choi@hotmail.com> To: freebsd-net@FreeBSD.org Subject: Re: kern/114714: [gre][patch] gre(4) is not MPSAFE and does not support keys Message-ID: <200807312150.m6VLo3ET087737@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/114714; it has been noted by GNATS. From: Wooseog Choi <ben_choi@hotmail.com> To: <bug-followup@freebsd.org>, <cristi@net.utcluj.ro> Cc: Subject: Re: kern/114714: [gre][patch] gre(4) is not MPSAFE and does not support keys Date: Thu, 31 Jul 2008 14:28:13 -0700 --_6b0f6d37-847d-4140-98e8-949ced352c50_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi=2C =20 My name is Ben Choi=2C working for Sandvine=2C Waterloo=2C ON=2C Canada. I had experienced similar issue=2C which was displaying many gre_out() cons= ole messages. At that moment=2C I could not access console at all. After applying the fix of MPSAFE codes only=2C it works fine.=20 No error messages on console at all. The benefit of this fix is two-fold. One=2C By removing all annoying messages=2C the console becomes accessible. Two=2C no gre packets are dropped by this incorrect error messages. =20 As the result=2C I think this code is worth to merge into official build. =20 Kind regards=2C =20 Ben Choi _________________________________________________________________ Keep your kids safer online with Windows Live Family Safety. http://www.windowslive.com/family_safety/overview.html?ocid=3DTXT_TAGLM_WL_= family_safety_072008= --_6b0f6d37-847d-4140-98e8-949ced352c50_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable <html> <head> <style> .hmmessage P { margin:0px=3B padding:0px } body.hmmessage { FONT-SIZE: 10pt=3B FONT-FAMILY:Tahoma } </style> </head> <body class=3D'hmmessage'> Hi=2C<BR>  =3B<BR> My name is Ben Choi=2C working for Sandvine=2C Waterloo=2C ON=2C Canada.<BR= > I had experienced similar issue=2C which was displaying many gre_out() cons= ole messages.<BR> At that moment=2C I could not access console at all.<BR> After applying the fix of MPSAFE codes only=2C it works fine. <BR> No error messages on console at all.<BR> The benefit of this fix is two-fold.<BR> One=2C By removing all annoying messages=2C the console becomes accessible.= <BR> Two=2C no gre packets are dropped by this incorrect error messages.<BR>  =3B<BR> As the result=2C I think this code is worth to merge into official build.<B= R>  =3B<BR> Kind regards=2C<BR>  =3B<BR> Ben Choi<BR><br /><hr />Keep your kids safer online with Windows Live Famil= y Safety. <a href=3D'http://www.windowslive.com/family_safety/overview.html= ?ocid=3DTXT_TAGLM_WL_family_safety_072008' target=3D'_new'>Help protect you= r kids.</a></body> </html>= --_6b0f6d37-847d-4140-98e8-949ced352c50_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807312150.m6VLo3ET087737>