Date: Sat, 20 Aug 2016 17:53:00 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-toolchain@FreeBSD.org Subject: [Bug 192320] Use of thread_local produces linking errors on system version of clang++ Message-ID: <bug-192320-29464-Dk5hFPLazY@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-192320-29464@https.bugs.freebsd.org/bugzilla/> References: <bug-192320-29464@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D192320 Bryan Drewery <bdrewery@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdrewery@FreeBSD.org --- Comment #13 from Bryan Drewery <bdrewery@FreeBSD.org> --- r303795 | kib | 2016-08-06 06:32:40 -0700 (Sat, 06 Aug 2016) | 37 lines Changed paths: M /head/lib/libc/include/libc_private.h M /head/lib/libc/stdlib/Makefile.inc M /head/lib/libc/stdlib/Symbol.map A /head/lib/libc/stdlib/cxa_thread_atexit.c M /head/lib/libc/stdlib/exit.c M /head/lib/libc/tests/stdlib/Makefile M /head/lib/libc/tests/stdlib/Makefile.depend A /head/lib/libc/tests/stdlib/cxa_thread_atexit_nothr_test.cc A /head/lib/libc/tests/stdlib/cxa_thread_atexit_test.cc M /head/lib/libthr/thread/thr_exit.c Add __cxa_thread_atexit(3) API implementation. This is the backing feature to implement C++11 thread storage duration specified by the thread_local keyword. A destructor for given thread-local object is registered to be executed at the thread termination time using __cxa_thread_atexit(). Libc calls the __cxa_thread_calls_dtors() during exit(3), before finalizers and atexit functions, and libthr calls the function at the thread termination time, after the stack unwinding and thread-specific key destruction. There are several uncertainties in the API which lacks a formal specification. Among them: - is it allowed to register destructors during destructing; we allow, but limiting the nesting level. If too many iterations detected, a diagnostic is issued to stderr and thread forcibly terminates for now. - how to handle destructors which belong to an unloading dso; for now, we ignore destructor calls for such entries, and issue a diagnostic. Linux does prevent dso unload until all threads with destructors from the dso terminated. It is supposed that the diagnostics allow to detect real-world applications relying on the above details and possibly adjust our implementation. Right now the choices were to provide the slim API (but that rarely stands the practice test). Tests are added to check generic functionality and to specify some of the above implementation choices. Submitted by: Mahdi Mokhtari <mokhi64_gmail.com> Reviewed by: theraven Discussed with: dim (detection of -std=3Dc++11 supoort for tests) Sponsored by: The FreeBSD Foundation (my involvement) MFC after: 2 weeks Differential revisions: https://reviews.freebsd.org/D7224, https://reviews.freebsd.org/D7427 --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192320-29464-Dk5hFPLazY>