Date: Tue, 15 Oct 2013 10:18:23 -0700 From: Sean Bruno <sean_bruno@yahoo.com> To: John-Mark Gurney <jmg@funkthat.com> Cc: freebsd-embedded@freebsd.org Subject: Re: makefs(8) proposed changes [repost from fs@] Message-ID: <1381857503.1855.0.camel@localhost> In-Reply-To: <20131015170403.GO56872@funkthat.com> References: <1380730546.1619.47.camel@localhost> <1381853252.2682.0.camel@localhost> <20131015170403.GO56872@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-RijlfbmQ6LrY8ZmI8DOg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Tue, 2013-10-15 at 10:04 -0700, John-Mark Gurney wrote: > Sean Bruno wrote this message on Tue, Oct 15, 2013 at 09:07 -0700: > > Is this patch going to break non "device" makefs calls? e.g. if I want > > to create an image file and not use a loopback device? >=20 > If the image file is zero bytes, then yes, it will break it... as the > read will return a short value (possibly zero) ... Why not add some > error checking and if the read doesn't read enough, write the > remaining bytes? If there is a failure from the read, the operation > should fail... >=20 yep, sounds good. =20 does this "proof of concept" code seem to make sense to you? sean --=-RijlfbmQ6LrY8ZmI8DOg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJSXXjVAAoJEBkJRdwI6BaHCz4H/1u2U6ESp4Q+yJSMeCWe4kZB rnYX098BLqf1iZ5YZfCPRSbRRBl8npsi43Cq5PzDdw1Y4wbKF6l75rHkuehx7c7d sgKhmaOcY/NPZkGl0r1HBaV+L4tBQUTBJsgx3/FYq2yllr3GPdbIbx2Rg3TEEbmG qNxnXOTiqYEVSv2ro4aTlqmBKDcjdxmE/5+fUxGzNMBOHNnwGqB1lOoFQiL1OX9b 8xb4+Op91+aEMCrCvu+Qm8sF/kx3OyG4nszfOx2UujK7doD/PQkgKj0CFzW826gs ZTigPqzeu2fzbn0OJVQhsacpsV4VsW377vwdUmm9Rivcaijnyz5giHUvNGDyaW0= =naaq -----END PGP SIGNATURE----- --=-RijlfbmQ6LrY8ZmI8DOg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1381857503.1855.0.camel>