Date: Mon, 08 Feb 2016 22:52:34 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 207034] ixv driver does not check_link or fill in adapter->link_speed field during initialization Message-ID: <bug-207034-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207034 Bug ID: 207034 Summary: ixv driver does not check_link or fill in adapter->link_speed field during initialization Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: jlott@averesystems.com Created attachment 166765 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D166765&action= =3Dedit Proposed patch I'm not 100% sure this is a bug, but the ixv driver does not fill in the link_speed field during initialization. Also the call to check_link during initialization does not actually check the link (these behaviors are relate= d). You can see this difference in a minor change in the "media" field displaye= d by ifconfig. Before applying my patch (media does not show "full-duplex"): ixv0: flags=3D8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500 =20=20=20=20=20=20=20 options=3D405bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM= ,TSO4,LRO,VLAN_HWTSO> ether 02:cf:31:b5:e9:19 inet 10.50.3.59 netmask 0xffffffc0 broadcast 10.50.3.63=20 nd6 options=3D29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL> media: Ethernet autoselect status: active --- After applying my patch (media shows some additional values): ixv0: flags=3D8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500 =20=20=20=20=20=20=20 options=3D405bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM= ,TSO4,LRO,VLAN_HWTSO> ether 02:cf:31:b5:e9:19 inet 10.50.3.59 netmask 0xffffffc0 broadcast 10.50.3.63=20 nd6 options=3D29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL> media: Ethernet autoselect (autoselect <full-duplex>) status: active --- It's not clear to me if the lack of check_link and adapter_speed being fill= ed in matters in any meaningful way. In particular, I'm not sure if it would b= e a problem if the link started as "down", since check_link is not called during init. I do my testing in EC2 and the link is always up there, so I can't ea= sily test that. Despite potentially not being a bug in functionality, the current behavior of the code was counter to my expectation, so I'm filing this so t= he maintainer can make a decision if the attached patch is worthwhile and/or correct. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207034-8>