Date: Tue, 21 Jan 2003 23:57:40 -0500 (EST) From: "Matthew N. Dodd" <winter@jurai.net> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: hackers@FreeBSD.ORG, Hiten Pandya <hiten@unixdaemons.com> Subject: Re: patch to remove random #define MIN/MAX implementations from around the kernel Message-ID: <20030121235501.N59276-100000@sasami.jurai.net> In-Reply-To: <200301220325.h0M3PiNt099890@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 21 Jan 2003, Matthew Dillon wrote: > This patch is going to go in on the weekend unless someone has any > worthwhile nits about it. It was submitted by Hiten Pandya. > > The patch basically removes random MIN/MAX implementations from > 22 files in the kernel and modifies the one in sys/param.h (see the > last part of the patch) so it is present for all kernel builds. I'd like to see all of these changed to the inlines in sys/libkern.h since the compiler will do type checking for us. This is a little more work which is why I didn't do it myself when I dealt with the abs() stuff. Consider this my objection. I don't think that it really stands in the way of the cleanup of all the definitions of min/max etc. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030121235501.N59276-100000>