Date: Sat, 31 May 2014 19:24:51 -0700 From: Matthew Luckie <mjl@luckie.org.nz> To: Guido Falsi <madpilot@FreeBSD.org> Cc: freebsd-ports@freebsd.org, Steve Kargl <sgk@troutmask.apl.washington.edu> Subject: Re: FreeBSD port graphics/xfig: patch to fix packaging with DOCS disabled (was Re: please revert graphics/xfig r354029) Message-ID: <20140601022451.GA27432@spandex.luckie.org.nz> In-Reply-To: <5389F676.2080708@FreeBSD.org> References: <20140531000800.GA57984@troutmask.apl.washington.edu> <5389D9B6.8030005@FreeBSD.org> <20140531143509.GA60572@troutmask.apl.washington.edu> <5389EE92.5070105@FreeBSD.org> <20140531150936.GA60696@troutmask.apl.washington.edu> <5389F676.2080708@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Please commit. Thanks Guido for doing the digging on this one.
On Sat, May 31, 2014 at 05:34:14PM +0200, Guido Falsi wrote:
> On 05/31/14 17:09, Steve Kargl wrote:
> > On Sat, May 31, 2014 at 05:00:34PM +0200, Guido Falsi wrote:
> >> On 05/31/14 16:35, Steve Kargl wrote:
> >>> On Sat, May 31, 2014 at 03:31:34PM +0200, Guido Falsi wrote:
> >>>> On 05/31/14 02:08, Steve Kargl wrote:
> >>>>> Can someone please revert r354029 for graphics/xfig?
> >>>>> This revision breaks the ability to install the port.
> >>>>>
> >>>>> cd /usr/ports/graphics/xfig
> >>>>> svn merge -r 354029:340725 .
> >>>>>
> >>>>
> >>>> Hi,
> >>>>
> >>>> I did commit the revision you mention. I just tested the port and it
> >>>> installs fine.
> >>>
> >>> Not on my system, which is an up-to-date freebsd-current.
> >>>
> >>
> >> After some digging I found out the port is broken when the DOCS option
> >> is disabled.
> >>
> >> I'm cooking a fix I'll get to you soon.
> >>
> >> Please always report if using custom options when reporting a problem.
> >>
> >=20
> > I forgot I had the DOCS option unset as it was unset ages ago
> > and updates have always worked. The question is "why are changes
> > to a port committed without proper testing?" Yes, "proper
> > testing" should include testing of the effects of (un)setting
> > individual Makefile options.
> >=20
>=20
> I'm going to fix it. I'm attaching a patch and CCing the maintainer to
> get his approval. Can you test this patch too and report back? Thanks!
>=20
> Please understand we all make mistakes from time to time.
>=20
> Also remember that this is a volunteer project and such a thorough
> testing as the one you are asking for isn't always possible with the
> resources at hand.
>=20
> for mjl@luckie.org.nz:
>=20
> A problem has been reported in the xfig port when trying to install it
> with the DOCS option disabled.
>=20
> I've created a patch which fixes the problem, can you approve it?
>=20
> Thanks in advance.
>=20
> --=20
> Guido Falsi <madpilot@FreeBSD.org>
> Index: Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- Makefile (revision 355988)
> +++ Makefile (working copy)
> @@ -24,6 +24,7 @@
> USE_XORG=3D ice sm x11 xaw xext xi xmu xpm xt
> USE_CSTD=3D gnu89
> CFLAGS+=3D -Wno-return-type
> +INSTALL_TARGET=3D install install.libs
> =20
> MAKE_ENV+=3D DOCSDIR=3D${DOCSDIR} CHMOD=3D${CHMOD} TAR=3D${TAR}
> MAKE_ARGS+=3D INSTALLFLAGS=3D"${COPY}" \
> @@ -38,7 +39,7 @@
> .include <bsd.port.options.mk>
> =20
> .if ${PORT_OPTIONS:MDOCS}
> -INSTALL_TARGET=3D install install.libs install.html
> +INSTALL_TARGET+=3D install.html
> .endif
> =20
> .if ! ${PORT_OPTIONS:MI18N} || ! ${PORT_OPTIONS:MDOCS}
--bp/iNruPH9dso1Pn
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iEYEARECAAYFAlOKjvMACgkQKyuDKSEQAGCgcgCeLt7at/odkYPGPpZpOiLDMGXs
rFAAn08jcMGmlL/+eTLn8xjFxukVn/1R
=k3K6
-----END PGP SIGNATURE-----
--bp/iNruPH9dso1Pn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140601022451.GA27432>