Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Feb 2010 12:31:11 -0800
From:      Garrett Cooper <yanefbsd@gmail.com>
To:        Poul-Henning Kamp <phk@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r203990 - head/lib/libc/sys
Message-ID:  <7d6fde3d1002171231u163ce4ao18478f4af6180d1b@mail.gmail.com>
In-Reply-To: <201002170911.o1H9BL6m095996@svn.freebsd.org>
References:  <201002170911.o1H9BL6m095996@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 17, 2010 at 1:11 AM, Poul-Henning Kamp <phk@freebsd.org> wrote:
> Author: phk
> Date: Wed Feb 17 09:11:21 2010
> New Revision: 203990
> URL: http://svn.freebsd.org/changeset/base/203990
>
> Log:
> =A0Mention EISDIR as a possible errno.
>
> Modified:
> =A0head/lib/libc/sys/unlink.2
>
> Modified: head/lib/libc/sys/unlink.2
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/lib/libc/sys/unlink.2 =A0Wed Feb 17 09:09:12 2010 =A0 =A0 =A0 =
=A0(r203989)
> +++ head/lib/libc/sys/unlink.2 =A0Wed Feb 17 09:11:21 2010 =A0 =A0 =A0 =
=A0(r203990)
> @@ -114,6 +114,8 @@ succeeds unless:
> =A0.Bl -tag -width Er
> =A0.It Bq Er ENOTDIR
> =A0A component of the path prefix is not a directory.
> +.It Bq Er EISDIR
> +The named file is a directory.
> =A0.It Bq Er ENAMETOOLONG
> =A0A component of a pathname exceeded 255 characters,
> =A0or an entire path name exceeded 1023 characters.

    This is wrong as per POSIX
(<http://www.opengroup.org/onlinepubs/000095399/functions/unlink.html>):

[EPERM]
The file named by path is a directory, and either the calling process
does not have appropriate privileges, or the implementation prohibits
using unlink() on directories.

    ... and the current manpage ...

     [EPERM]            The named file is a directory.

    The manpage needs to be modified to note that, or the offender
needs to be fixed.

Thanks,
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d1002171231u163ce4ao18478f4af6180d1b>