Date: Tue, 13 Dec 2016 22:24:35 +0100 From: Jilles Tjoelker <jilles@stack.nl> To: Devin Teske <dteske@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309918 - head/usr.sbin/bsdinstall/scripts Message-ID: <20161213212435.GA34587@stack.nl> In-Reply-To: <201612121848.uBCIm00M073404@repo.freebsd.org> References: <201612121848.uBCIm00M073404@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 12, 2016 at 06:48:00PM +0000, Devin Teske wrote: > Author: dteske > Date: Mon Dec 12 18:48:00 2016 > New Revision: 309918 > URL: https://svnweb.freebsd.org/changeset/base/309918 > Log: > Remove unnecessary `-n' parameter to head/tail These -n options are not completely unnecessary since POSIX removed the obsolete forms without -n years ago, and some minimalistic implementations (Busybox) followed suit. Therefore, although I use the obsolete forms frequently interactively, I think head/tail -n should be the preferred form in scripts. The obsolete form tail +N (where N is a number) should definitely be avoided since it conflicts with a file named like that; head -N and tail -N are valid extensions to the standard. > Modified: > head/usr.sbin/bsdinstall/scripts/wlanconfig > > Modified: head/usr.sbin/bsdinstall/scripts/wlanconfig > ============================================================================== > --- head/usr.sbin/bsdinstall/scripts/wlanconfig Mon Dec 12 18:45:52 2016 (r309917) > +++ head/usr.sbin/bsdinstall/scripts/wlanconfig Mon Dec 12 18:48:00 2016 (r309918) > @@ -175,8 +175,8 @@ fi > # > if [ "$BSDINSTALL_CONFIGCURRENT" ]; then > # Get current country/regdomain for selected interface > - WLAN_IFACE=$( wpa_cli ifname | tail -n 1 ) > - INPUT=$( ifconfig $WLAN_IFACE list regdomain | head -n 1 ) > + WLAN_IFACE=$( wpa_cli ifname | tail -1 ) > + INPUT=$( ifconfig $WLAN_IFACE list regdomain | head -1 ) > DEF_REGDOMAIN=$( echo $INPUT | cut -w -f 2 ) > DEF_COUNTRY=$( echo $INPUT | cut -w -f 4 ) > [ "$DEF_REGDOMAIN" = 0 ] && DEF_REGDOMAIN="<not selected>" -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161213212435.GA34587>