Date: Mon, 2 May 2011 13:44:05 +0800 From: Adrian Chadd <adrian@freebsd.org> To: freebsd-wireless@freebsd.org Subject: [net80211] patch: make aggressive mode a compile time option Message-ID: <BANLkTikyjJXtWDaUN2rHzyM=yCTsUh=JPA@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--20cf307d064cfa710004a24482fa Content-Type: text/plain; charset=ISO-8859-1 Right now aggressive mode is enabled by default. This twiddles the WME parameters for the bulk data queue to allow bursting if there's no data on the higher priority queues. This patch disables it by default and adds a new compile time option that restores the previous behaviour. I'd like to suggest this be disabled by default as it differs from the "specification" 802.11e behaviour and I'm not yet entirely convinced it's working correctly. Specifically, I've seen hostap setups set the wme beacon field to the aggressive mode parameters but not update the wlan interface with them; making the AP wlan interface nconsistent with th erest of the stations. I'm open to making it on by default but still make it easy to disable as a build-time option. Thanks, Adrian --20cf307d064cfa710004a24482fa Content-Type: application/octet-stream; name="aggrmode-optional.diff" Content-Disposition: attachment; filename="aggrmode-optional.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gn6zhpi10 SW5kZXg6IHN5cy9jb25mL29wdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2NvbmYvb3B0aW9ucwko cmV2aXNpb24gMjIxMzEyKQorKysgc3lzL2NvbmYvb3B0aW9ucwkod29ya2luZyBjb3B5KQpAQCAt ODM5LDYgKzgzOSw3IEBACiBJRUVFODAyMTFfU1VQUE9SVF9TVVBFUkcJb3B0X3dsYW4uaAogSUVF RTgwMjExX1NVUFBPUlRfVERNQQlvcHRfd2xhbi5oCiBJRUVFODAyMTFfQUxRCQlvcHRfd2xhbi5o CitJRUVFODAyMTFfU1VQUE9SVF9BR0dSTU9ERQlvcHRfd2xhbi5oCiAKICMgODAyLjExIFRETUEg c3VwcG9ydAogVERNQV9TTE9UTEVOX0RFRkFVTFQJb3B0X3RkbWEuaApJbmRleDogc3lzL25ldDgw MjExL2llZWU4MDIxMV9vdXRwdXQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvbmV0ODAyMTEvaWVlZTgw MjExX291dHB1dC5jCShyZXZpc2lvbiAyMjA5MTEpCisrKyBzeXMvbmV0ODAyMTEvaWVlZTgwMjEx X291dHB1dC5jCSh3b3JraW5nIGNvcHkpCkBAIC0yODIwLDYgKzI4MjAsNyBAQAogCWlmICh2YXAt Pml2X2ZsYWdzICYgSUVFRTgwMjExX0ZfV01FKSB7CiAJCXN0cnVjdCBpZWVlODAyMTFfd21lX3N0 YXRlICp3bWUgPSAmaWMtPmljX3dtZTsKIAorI2lmZGVmCUlFRUU4MDIxMV9TVVBQT1JUX0FHR1JN T0RFCiAJCS8qCiAJCSAqIENoZWNrIGZvciBhZ3Jlc3NpdmUgbW9kZSBjaGFuZ2UuICBXaGVuIHRo ZXJlIGlzCiAJCSAqIHNpZ25pZmljYW50IGhpZ2ggcHJpb3JpdHkgdHJhZmZpYyBpbiB0aGUgQlNT CkBAIC0yODUyLDYgKzI4NTMsOCBAQAogCQkJCXdtZS0+d21lX2hpcHJpX3RyYWZmaWMgPQogCQkJ CQl3bWUtPndtZV9oaXByaV9zd2l0Y2hfaHlzdGVyZXNpczsKIAkJfQorI2VuZGlmCS8qIElFRUU4 MDIxMV9TVVBQT1JUX0FHR1JNT0RFICovCisKIAkJaWYgKGlzc2V0KGJvLT5ib19mbGFncywgSUVF RTgwMjExX0JFQUNPTl9XTUUpKSB7CiAJCQkodm9pZCkgaWVlZTgwMjExX2FkZF93bWVfcGFyYW0o Ym8tPmJvX3dtZSwgd21lKTsKIAkJCWNscmJpdChiby0+Ym9fZmxhZ3MsIElFRUU4MDIxMV9CRUFD T05fV01FKTsKSW5kZXg6IHN5cy9uZXQ4MDIxMS9pZWVlODAyMTFfcHJvdG8uYwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBzeXMvbmV0ODAyMTEvaWVlZTgwMjExX3Byb3RvLmMJKHJldmlzaW9uIDIyMDkxMSkKKysr IHN5cy9uZXQ4MDIxMS9pZWVlODAyMTFfcHJvdG8uYwkod29ya2luZyBjb3B5KQpAQCAtOTc0LDYg Kzk3NCw3IEBACiB2b2lkCiBpZWVlODAyMTFfd21lX3VwZGF0ZXBhcmFtc19sb2NrZWQoc3RydWN0 IGllZWU4MDIxMXZhcCAqdmFwKQogeworI2lmZGVmCUlFRUU4MDIxMV9TVVBQT1JUX0FHR1JNT0RF CiAJc3RhdGljIGNvbnN0IHBhcmFtVHlwZSBhZ2dyUGFyYW1bSUVFRTgwMjExX01PREVfTUFYXSA9 IHsKIAkgICAgW0lFRUU4MDIxMV9NT0RFX0FVVE9dCT0geyAyLCA0LCAxMCwgNjQsIDAgfSwKIAkg ICAgW0lFRUU4MDIxMV9NT0RFXzExQV0JPSB7IDIsIDQsIDEwLCA2NCwgMCB9LApAQCAtOTg4LDEw ICs5ODksMTQgQEAKIAkgICAgW0lFRUU4MDIxMV9NT0RFXzExTkFdCT0geyAyLCA0LCAxMCwgNjQs IDAgfSwJLyogWFhYY2hlY2sqLwogCSAgICBbSUVFRTgwMjExX01PREVfMTFOR10JPSB7IDIsIDQs IDEwLCA2NCwgMCB9LAkvKiBYWFhjaGVjayovCiAJfTsKKwlzdHJ1Y3Qgd21lUGFyYW1zICpic3Nw OworCisjZW5kaWYJLyogSUVFRTgwMjExX1NVUFBPUlRfQUdHUk1PREUgKi8KKwogCXN0cnVjdCBp ZWVlODAyMTFjb20gKmljID0gdmFwLT5pdl9pYzsKIAlzdHJ1Y3QgaWVlZTgwMjExX3dtZV9zdGF0 ZSAqd21lID0gJmljLT5pY193bWU7CiAJY29uc3Qgc3RydWN0IHdtZVBhcmFtcyAqd21lcDsKLQlz dHJ1Y3Qgd21lUGFyYW1zICpjaGFucCwgKmJzc3A7CisJc3RydWN0IHdtZVBhcmFtcyAqY2hhbnA7 CiAJZW51bSBpZWVlODAyMTFfcGh5bW9kZSBtb2RlOwogCWludCBpOwogCkBAIC0xMDI2LDYgKzEw MzEsNyBAQAogCWVsc2UKIAkJbW9kZSA9IElFRUU4MDIxMV9NT0RFX0FVVE87CiAKKyNpZmRlZglJ RUVFODAyMTFfU1VQUE9SVF9BR0dSTU9ERQogCS8qCiAJICogVGhpcyBpbXBsZW1lbnRzIGFncmVz c2l2ZSBtb2RlIGFzIGZvdW5kIGluIGNlcnRhaW4KIAkgKiB2ZW5kb3JzJyBBUCdzLiAgV2hlbiB0 aGVyZSBpcyBzaWduaWZpY2FudCBoaWdoCkBAIC0xMDgxLDYgKzEwODcsOCBAQAogCQkgICAgInVw ZGF0ZSAlcyAoY2hhbitic3MpIGxvZ2N3bWluICV1XG4iLAogCQkgICAgaWVlZTgwMjExX3dtZV9h Y25hbWVzW1dNRV9BQ19CRV0sIGNoYW5wLT53bWVwX2xvZ2N3bWluKTsKICAgICAJfQkKKyNlbmRp ZgkvKiBJRUVFODAyMTFfU1VQUE9SVF9BR0dSTU9ERSAqLworCiAJaWYgKHZhcC0+aXZfb3Btb2Rl ID09IElFRUU4MDIxMV9NX0hPU1RBUCkgewkvKiBYWFggaWJzcz8gKi8KIAkJLyoKIAkJICogQXJy YW5nZSBmb3IgYSBiZWFjb24gdXBkYXRlIGFuZCBidW1wIHRoZSBwYXJhbWV0ZXIK --20cf307d064cfa710004a24482fa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTikyjJXtWDaUN2rHzyM=yCTsUh=JPA>