Date: Thu, 18 Feb 2010 07:41:12 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Garrett Cooper <yanefbsd@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Poul-Henning Kamp <phk@freebsd.org>, Bruce Evans <brde@optusnet.com.au> Subject: Re: svn commit: r203990 - head/lib/libc/sys Message-ID: <20100218073347.O2621@besplex.bde.org> In-Reply-To: <7d6fde3d1002171225n5b6ebc2eyb85ffbfacb594da9@mail.gmail.com> References: <201002170911.o1H9BL6m095996@svn.freebsd.org> <20100218044931.S95007@delplex.bde.org> <20100218055229.Q1735@besplex.bde.org> <7d6fde3d1002171225n5b6ebc2eyb85ffbfacb594da9@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-828759399-1266439272=:2621 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 17 Feb 2010, Garrett Cooper wrote: > On Wed, Feb 17, 2010 at 11:13 AM, Bruce Evans <brde@optusnet.com.au> wrot= e: >> On Thu, 18 Feb 2010, Bruce Evans wrote: >>>> ... >> >> Related bug: unlink(1) bogusly prints a messages that looks like >> strerror(EISDIR). =A0It doesn't even try unlink(2) on directories, >> but prints this message from a private string. >> ... >> Anyway, unlink(1) shouldn't fall into rm(1)'s error handling to to >> print its diagnostic. =A0It should use a special message (matching its >> man page) for directories, or just try unlink(2). >> >> rm(1)'s current special message should say something about directory >> removal requiring -d, and not look like strerror(EISDIR). =A0Or since >> directory removal is prohibited by the kernel, the -d option can never >> work, so it should have been removed ~10 years ago when the kernel was >> changed to prohibit it. > > 1. Where is EISDIR used in rm(1)? Nowhere. As described above, unlink[rm](1) prints a message that looks like sterror(EISDIR) from a private string. It doesn't even fake the string properly (the real message capitalizes "Is"). > 2. phk's example in a latter email used unlink(2), not unlink(1). My first reply was about unlink(2). My second reply was originally about the related bug in unlink(1) but expanded to cover related bugs in rm(1). Bruce --0-828759399-1266439272=:2621--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100218073347.O2621>