Date: Wed, 16 Jan 2013 22:40:51 -0500 From: Eitan Adler <eadler@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI <delphij@freebsd.org> Subject: Re: svn commit: r245506 - head/bin/pwait Message-ID: <CAF6rxg=RBJ280qe=ZAbPYBV-uXcjBYFTqCXP%2Bi_LzpMSi2aHkg@mail.gmail.com> In-Reply-To: <20130117130740.I1066@besplex.bde.org> References: <201301161815.r0GIFQPk007553@svn.freebsd.org> <20130117130740.I1066@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 January 2013 21:25, Bruce Evans <brde@optusnet.com.au> wrote: > This uses the sysexits mistake. style(9) was fixed to not give an example > of this mistake. Before this, sysexits was used a whole once in pwait(1) > (for EX_USAGE) in usage(). EX_USAGE happens to be 64. As usual when the > mistake is used, this is useless for humans (the usage message gives more > info) and unusable for programs, especially since it is undocmented > (pwait(1)'s man page just says ">0 if an error occurs". It doesn't even > use '.Std' for this, but hard-codes it. IMHO using sysexits gives more signal than using a binary 0 or 1. It is a mistake to have changed style(9) to avoid using sysexits. Instead the man page should detail the specific error that occurs directly, or by reference to sysexit. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=RBJ280qe=ZAbPYBV-uXcjBYFTqCXP%2Bi_LzpMSi2aHkg>