Date: Wed, 13 Feb 2008 05:05:57 -0800 From: David Wolfskill <david@catwhisker.org> To: stable@freebsd.org, i386@freebsd.org Cc: jhb@freebsd.org Subject: Re: [releng_6 tinderbox] failure on i386/i386 Message-ID: <20080213130557.GU53191@bunrab.catwhisker.org> In-Reply-To: <20080213113312.6AEF4241A2@freebsd-legacy.sentex.ca> References: <20080213113312.6AEF4241A2@freebsd-legacy.sentex.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--/qX1VF4Euib7a2dq
Content-Type: multipart/mixed; boundary="Oodyc6ouB/5xmHkU"
Content-Disposition: inline
--Oodyc6ouB/5xmHkU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Feb 13, 2008 at 06:33:12AM -0500, FreeBSD Tinderbox wrote:
> [...]
> cc -c -O2 -pipe -fno-strict-aliasing -Wall -Wredundant-decls -Wnested-ex=
terns -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -W=
cast-qual -fformat-extensions -std=3Dc99 -nostdinc -I- -I. -I/src/sys -I=
/src/sys/contrib/altq -I/src/sys/contrib/ipfilter -I/src/sys/contrib/pf -I/=
src/sys/dev/ath -I/src/sys/contrib/ngatm -I/src/sys/dev/twa -I/src/sys/dev/=
em -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common=
-finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-funct=
ion-growth=3D1000 -DGPROF -falign-functions=3D16 -DGPROF4 -DGUPROF -fno-bui=
ltin -mno-align-long-strings -mpreferred-stack-boundary=3D2 -mno-mmx -mno-=
3dnow -mno-sse -mno-sse2 -ffreestanding -Werror -pg -mprofiler-epilogue /sr=
c/sys/i386/ibcs2/ibcs2_xenix.c
> cc -c -O2 -pipe -fno-strict-aliasing -Wall -Wredundant-decls -Wnested-ex=
terns -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -W=
cast-qual -fformat-extensions -std=3Dc99 -nostdinc -I- -I. -I/src/sys -I=
/src/sys/contrib/altq -I/src/sys/contrib/ipfilter -I/src/sys/contrib/pf -I/=
src/sys/dev/ath -I/src/sys/contrib/ngatm -I/src/sys/dev/twa -I/src/sys/dev/=
em -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common=
-finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-funct=
ion-growth=3D1000 -DGPROF -falign-functions=3D16 -DGPROF4 -DGUPROF -fno-bui=
ltin -mno-align-long-strings -mpreferred-stack-boundary=3D2 -mno-mmx -mno-=
3dnow -mno-sse -mno-sse2 -ffreestanding -Werror -pg -mprofiler-epilogue /sr=
c/sys/i386/ibcs2/ibcs2_xenix_sysent.c
> cc -c -O2 -pipe -fno-strict-aliasing -Wall -Wredundant-decls -Wnested-ex=
terns -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -W=
cast-qual -fformat-extensions -std=3Dc99 -nostdinc -I- -I. -I/src/sys -I=
/src/sys/contrib/altq -I/src/sys/contrib/ipfilter -I/src/sys/contrib/pf -I/=
src/sys/dev/ath -I/src/sys/contrib/ngatm -I/src/sys/dev/twa -I/src/sys/dev/=
em -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common=
-finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-funct=
ion-growth=3D1000 -DGPROF -falign-functions=3D16 -DGPROF4 -DGUPROF -fno-bui=
ltin -mno-align-long-strings -mpreferred-stack-boundary=3D2 -mno-mmx -mno-=
3dnow -mno-sse -mno-sse2 -ffreestanding -Werror -pg -mprofiler-epilogue /sr=
c/sys/i386/ibcs2/imgact_coff.c
> cc -c -O2 -pipe -fno-strict-aliasing -Wall -Wredundant-decls -Wnested-ex=
terns -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -W=
cast-qual -fformat-extensions -std=3Dc99 -nostdinc -I- -I. -I/src/sys -I=
/src/sys/contrib/altq -I/src/sys/contrib/ipfilter -I/src/sys/contrib/pf -I/=
src/sys/dev/ath -I/src/sys/contrib/ngatm -I/src/sys/dev/twa -I/src/sys/dev/=
em -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common=
-finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-funct=
ion-growth=3D1000 -DGPROF -falign-functions=3D16 -DGPROF4 -DGUPROF -fno-bui=
ltin -mno-align-long-strings -mpreferred-stack-boundary=3D2 -mno-mmx -mno-=
3dnow -mno-sse -mno-sse2 -ffreestanding -Werror -pg -mprofiler-epilogue /sr=
c/sys/i386/isa/atpic.c
> cc -c -O2 -pipe -fno-strict-aliasing -Wall -Wredundant-decls -Wnested-ex=
terns -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -W=
cast-qual -fformat-extensions -std=3Dc99 -nostdinc -I- -I. -I/src/sys -I=
/src/sys/contrib/altq -I/src/sys/contrib/ipfilter -I/src/sys/contrib/pf -I/=
src/sys/dev/ath -I/src/sys/contrib/ngatm -I/src/sys/dev/twa -I/src/sys/dev/=
em -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common=
-finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-funct=
ion-growth=3D1000 -DGPROF -falign-functions=3D16 -DGPROF4 -DGUPROF -fno-bui=
ltin -mno-align-long-strings -mpreferred-stack-boundary=3D2 -mno-mmx -mno-=
3dnow -mno-sse -mno-sse2 -ffreestanding -Werror -pg -mprofiler-epilogue /sr=
c/sys/i386/isa/clock.c
> /src/sys/i386/isa/clock.c: In function `DELAY':
> /src/sys/i386/isa/clock.c:301: warning: implicit declaration of function =
`cpu_spinwait'
> /src/sys/i386/isa/clock.c:301: warning: nested extern declaration of `cpu=
_spinwait'
> *** Error code 1
>=20
> Stop in /obj/src/sys/LINT.
> *** Error code 1
>=20
> Stop in /src.
> *** Error code 1
>=20
> Stop in /src.
> TB --- 2008-02-13 11:33:12 - WARNING: /usr/bin/make returned exit code 1=
=20
> TB --- 2008-02-13 11:33:12 - ERROR: failed to build lint kernel
> TB --- 2008-02-13 11:33:12 - tinderbox aborted
> TB --- 3164.52 user 372.58 system 4015.77 real
Looks as if the MFC for sys/${arch}/isa/clock.c missed adding
#include <machine/cpu.h>
to the file.
For i386, the attached patch fixes it; a similar patch is likely wanted
for other values of ${arch}.
Peace,
david
--=20
David H. Wolfskill david@catwhisker.org
I submit that "conspiracy" would be an appropriate collective noun for cats.
See http://www.catwhisker.org/~david/publickey.gpg for my public key.
--Oodyc6ouB/5xmHkU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="clock.c.diff"
Content-Transfer-Encoding: quoted-printable
Index: sys/i386/isa/clock.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/freebsd/src/sys/i386/isa/clock.c,v
retrieving revision 1.222.2.4
diff -u -r1.222.2.4 clock.c
--- sys/i386/isa/clock.c 12 Feb 2008 19:14:01 -0000 1.222.2.4
+++ sys/i386/isa/clock.c 13 Feb 2008 12:58:41 -0000
@@ -70,6 +70,7 @@
#include <sys/power.h>
=20
#include <machine/clock.h>
+#include <machine/cpu.h>
#include <machine/cputypes.h>
#include <machine/frame.h>
#include <machine/intr_machdep.h>
--Oodyc6ouB/5xmHkU--
--/qX1VF4Euib7a2dq
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)
iEYEARECAAYFAkey6zQACgkQmprOCmdXAD2HwwCdFLTw09f5oypW4oCkphg21rFa
f+cAn1q1J8+ZJAxEraVwdSykq+mqkXHJ
=rhBF
-----END PGP SIGNATURE-----
--/qX1VF4Euib7a2dq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080213130557.GU53191>