Date: Fri, 14 Jul 1995 03:10:04 -0700 From: peter@haywire.dialix.com To: freebsd-bugs Subject: bin/613: send-pr reports wrong release Message-ID: <199507141010.DAA01518@freefall.cdrom.com> In-Reply-To: Your message of Fri, 14 Jul 1995 18:04:26 %2B0800 <199507141004.SAA07402@jhome.DIALix.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
>Number: 613 >Category: bin >Synopsis: send-pr reports wrong release >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs (FreeBSD bugs mailing list) >State: open >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jul 14 03:10:02 1995 >Originator: Peter Wemm >Organization: DIALix >Release: FreeBSD 2.0-BUILT-19950517 i386 >Environment: uname -rsm: FreeBSD 2.2-CURRENT i386 supped earlier today, followed by a "make all install" >Description: As you can see a few lines up, send-pr is _still_ claiming that the "Release" is several months old, even though everything is as recent as it can get, and compiled and installed. The problem is, that the Makefile generates obj/send-pr from send-pr.sh *once* and never, ever updates it, because there are no dependencies to cause it to be regenerated. >How-To-Repeat: use send-pr.. :-) >Fix: The makefile uses a sed command to substitute @DEFAULT_RELEASE@ with the output of "uname -rsm" at build initial build time. IMHO, this has to be done at run-time, otherwise the ">Release:" header is pretty much meaningless. If a more meaningful Release header is to be generated in the future, perhaps for routing the PR, then it will have to do other things to generate it's release string at run-time, or "obj/send-pr.sh" is going to need to be rebuilt every single time there is a make in the directory.. (requiring a make clean beforehand is not an option..) *** send-pr.sh.broken Fri Jul 14 17:49:58 1995 --- send-pr.sh Wed Jul 12 03:54:57 1995 *************** *** 40,46 **** [ ! -d $DATADIR/gnats -a -d "$GCC_EXEC_PREFIX" ] && DATADIR=@DATADIR@ # The default release for this host. ! DEFAULT_RELEASE="@DEFAULT_RELEASE@" # The default organization. DEFAULT_ORGANIZATION= --- 40,49 ---- [ ! -d $DATADIR/gnats -a -d "$GCC_EXEC_PREFIX" ] && DATADIR=@DATADIR@ # The default release for this host. ! #DEFAULT_RELEASE="@DEFAULT_RELEASE@" ! DEFAULT_RELEASE=`( [ -f /bin/uname ] && /bin/uname -rsm ) || \ ! ( [ -f /usr/bin/uname ] && /usr/bin/uname -rsm ) || \ ! echo "@DEFAULT_RELEASE@"` # The default organization. DEFAULT_ORGANIZATION= >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507141010.DAA01518>