Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 02 Nov 2001 01:01:33 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Mitsuru IWASAKI <iwasaki@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   RE: cvs commit: src/sys/conf files src/sys/dev/acpica acpi.c src
Message-ID:  <XFMail.011102010133.jhb@FreeBSD.org>
In-Reply-To: <200111011634.fA1GY8M18688@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 01-Nov-01 Mitsuru IWASAKI wrote:
> iwasaki     2001/11/01 08:34:08 PST
> 
>   Modified files:
>     sys/conf             files 
>     sys/dev/acpica       acpi.c 
>     sys/dev/syscons      syscons.c 
>     sys/i386/apm         apm.c 
>     sys/i386/isa         clock.c 
>     sys/sys              kernel.h 
>   Added files:
>     sys/kern             subr_power.c 
>     sys/sys              power.h 
>   Log:
>   Some fix for the recent apm module changes.
>    - Now that apm loadable module can inform its existence to other kernel
>      components  (e.g. i386/isa/clock.c:startrtclock()'s TCS hack).
>    - Exchange priority of SI_SUB_CPU and SI_SUB_KLD for above purpose.
>    - Add simple arbitration mechanism for APM vs. ACPI.  This prevents
>      the kernel enables both of them.
>    - Remove obsolete `#ifdef DEV_APM' related code.
>    - Add abstracted interface for Powermanagement operations.  Public apm(4)
>      functions, such as apm_suspend(), should be replaced new interfaces.
>      Currently only power_pm_suspend (successor of apm_suspend) is
> implemented.
>   
>   Reviewed by:        peter, arch@ and audit@

Hmm, I actually really don't like swapping those SYSINIT's.  Probably what you
should do is do whwat the alpha does and initalize the timecounters during the
SI_SUB_CLOCKS sysinit.  If SI_SUB_CLOCKS is before SI_SUB_KLD, then you should
create a SI_SUB_TC after SI_SUB_KLD and initialize timecounters there. 
Logically, we need the CPU up and initialized before we start trying to figure
out what modules we have and how to init them.  At least IMO.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011102010133.jhb>