Date: Tue, 21 Jan 2003 21:26:36 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Kris Kennaway <kris@obsecurity.org>, hackers@FreeBSD.ORG, Hiten Pandya <hiten@unixdaemons.com> Subject: Re: patch to remove random #define MIN/MAX implementations from around the kernel Message-ID: <20030122052636.GA25050@rot13.obsecurity.org> In-Reply-To: <200301220402.h0M42xBo000193@apollo.backplane.com> References: <200301220325.h0M3PiNt099890@apollo.backplane.com> <20030121195803.A32701@citusc.usc.edu> <200301220402.h0M42xBo000193@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--/04w6evG8XlLl3ft Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 21, 2003 at 08:02:59PM -0800, Matthew Dillon wrote: > :You shouldn't modify vendor code for minor purposes. > : > :Kris >=20 > The vendor code in question has been modified *extensively* since > it was imported, (and of course I would give Darren a head's up in > regards to ipfilter). Unless you have a more specific reason I don't > really think a general blanket statement is sufficient reason to not > do the commit, at least not in this case. I think you need to respect vendor code, and the FreeBSD committers who maintain it. Kris --/04w6evG8XlLl3ft Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+LiuLWry0BWjoQKURAj7lAKDEAQFmznNxGSP+5jvKIDkrCD7l5QCgwhI1 qr8sLV+sFKnoasGUe1TCeyQ= =iQqz -----END PGP SIGNATURE----- --/04w6evG8XlLl3ft-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030122052636.GA25050>