Date: Fri, 2 May 2003 01:08:45 -0500 (CDT) From: Mike Silbersack <silby@silby.com> To: freebsd-net@freebsd.org Subject: More mbuf INVARIANTS code, comments needed Message-ID: <20030502010545.U610@odysseus.silby.com>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1806121823-1051855725=:610 Content-Type: TEXT/PLAIN; charset=US-ASCII Now that I have the double-free code in (under INVARIANTS), I'm considering the attached patch as well; it fills the m_data, m_next, and m_nextpkt fields with non-NULL garbage in hopes that any uses after free will be immediately fatal. Does anyone see problems with this, and/or other simple checks that could be added cheaply? Thanks, Mike "Silby" Silbersack --0-1806121823-1051855725=:610 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="mbuf_more_invariants.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20030502010845.J610@odysseus.silby.com> Content-Description: Content-Disposition: attachment; filename="mbuf_more_invariants.patch" ZGlmZiAtdSAtciAvdXNyL3NyYy9zeXMub2xkL2tlcm4vc3Vicl9tYnVmLmMg L3Vzci9zcmMvc3lzL2tlcm4vc3Vicl9tYnVmLmMNCi0tLSAvdXNyL3NyYy9z eXMub2xkL2tlcm4vc3Vicl9tYnVmLmMJVGh1IE1heSAgMSAyMjo1NTowOSAy MDAzDQorKysgL3Vzci9zcmMvc3lzL2tlcm4vc3Vicl9tYnVmLmMJRnJpIE1h eSAgMiAwMDo1MzowOCAyMDAzDQpAQCAtMTQwNCw2ICsxNDA0LDEyIEBADQog CQkJfQ0KIAkJfQ0KIAl9DQorI2lmZGVmIElOVkFSSUFOVFMNCisJLyogRmls bCB3aXRoIGp1bmsgZGF0YSB0byBwcm92b2tlIHBhbmljcyBmcm9tIGFjY2Vz c2VzIGFmdGVyIGZyZWUgKi8NCisJbWItPm1fZGF0YSA9ICh2b2lkICopIDB4 MTM3Ow0KKwltYi0+bV9uZXh0ID0gKHZvaWQgKikgMHgxMzg7DQorCW1iLT5t X25leHRwa3QgPSAodm9pZCAqKSAweDEzOTsNCisjZW5kaWYNCiAJbWJfZnJl ZSgmbWJfbGlzdF9tYnVmLCBtYiwgbWItPm1fdHlwZSwgcGVyc2lzdCwgJmNj aG51bSk7DQogCXJldHVybiAobmIpOw0KIH0NCkBAIC0xNDUzLDYgKzE0NTks MTIgQEANCiAJCQkJfQ0KIAkJCX0NCiAJCX0NCisjaWZkZWYgSU5WQVJJQU5U Uw0KKwkJLyogRmlsbCB3aXRoIGp1bmsgZGF0YSB0byBwcm92b2tlIHBhbmlj cyBmcm9tIGFjY2Vzc2VzIGFmdGVyIGZyZWUgKi8NCisJCW0tPm1fZGF0YSA9 ICh2b2lkICopIDB4MTM3Ow0KKwkJbS0+bV9uZXh0ID0gKHZvaWQgKikgMHgx Mzg7DQorCQltLT5tX25leHRwa3QgPSAodm9pZCAqKSAweDEzOTsNCisjZW5k aWYNCiAJCW1iX2ZyZWUoJm1iX2xpc3RfbWJ1ZiwgbSwgbS0+bV90eXBlLCBw ZXJzaXN0LCAmY2NobnVtKTsNCiAJfQ0KIH0NCg== --0-1806121823-1051855725=:610--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030502010545.U610>