Date: Tue, 12 Jul 2011 16:46:50 GMT From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/158840: [PATCH] comms/gammu: plist is broken if shells/bash is installed Message-ID: <201107121646.p6CGkod5013771@red.freebsd.org> Resent-Message-ID: <201107121650.p6CGoCfK063400@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 158840
>Category: ports
>Synopsis: [PATCH] comms/gammu: plist is broken if shells/bash is installed
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Jul 12 16:50:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Ruslan Mahmatkhanov
>Release: 9.0-CURRENT
>Organization:
>Environment:
9.0-CURRENT i386
>Description:
If bash is installed, comms/gammu installs this file:
/etc/bash_completion.d/gammu and leaves it upon deinstall.
So the problem is (in case of bash installed):
- gammu installs files to /etc
- plist is broken in case of bash installed.
The first issue can be fixed with patch attached, but the second one
needs some cmake or ports foo to install this completion script only
if bash is installed/requested.
Maintainer already notified and i filed this pr by his request as
reminder.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
--- Makefile.orig 2011-05-23 18:17:17.000000000 +0400
+++ Makefile 2011-07-12 20:36:17.000000000 +0400
@@ -50,6 +50,9 @@
post-patch:
@${REINPLACE_CMD} -i '' -e 's:bash:sh:' -e 's:dialog:cdialog:' ${WRKSRC}/utils/gammu-config
+ @${REINPLACE_CMD} -e 's:/etc/bash_completion.d:${PREFIX}/etc/bash_completion.d:' \
+ ${WRKSRC}/contrib/CMakeLists.txt
+
.if ${OSVERSION} < 700042
@${REINPLACE_CMD} -e 's@ -Wno-pointer-sign@@g' ${WRKSRC}/CMakeLists.txt
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107121646.p6CGkod5013771>