Date: Tue, 30 Sep 2003 15:20:13 -0700 (PDT) From: Michael Nottebrock <michaelnottebrock@gmx.net> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/57290: New port: audio/yammi, a QT music manager with fuzzy search capabilities Message-ID: <200309302220.h8UMKDiR064534@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/57290; it has been noted by GNATS. From: Michael Nottebrock <michaelnottebrock@gmx.net> To: freebsd-gnats-submit@FreeBSD.org, avleeuwen@piwebs.com Cc: Subject: Re: ports/57290: New port: audio/yammi, a QT music manager with fuzzy search capabilities Date: Tue, 30 Sep 2003 20:43:04 +0200 --Boundary-00=_56ce/EhiYUt0Aq+ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline There are a few issues with this shar, see attached patch. The PORTVERSION may not contain strings like "rc" (reference http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html#PORTING-PKGNAME ). The additional CONFIGURE_ENV is needed to make the configure check for libkdecore work. Finally, make sure to always check for leftover space-separators ;). Please review. Personal note: While not a criterion for inclusion in ports, the buggyness of this software is so severe, that I suggest you really think again about submitting this port right now. During very superficial testing, I encountered several crashes in core functionality (like SIGSEVS while scanning for media, apparently if ID3 tags or Ogg Comments return unexpected strings). --Boundary-00=_56ce/EhiYUt0Aq+ Content-Type: text/x-diff; charset="us-ascii"; name="yammi.diff" Content-Transfer-Encoding: 8bit Content-Disposition: inline; filename="yammi.diff" diff -urN yammi.orig/Makefile yammi/Makefile --- yammi.orig/Makefile Tue Sep 30 20:34:38 2003 +++ yammi/Makefile Tue Sep 30 20:28:48 2003 @@ -6,11 +6,11 @@ # PORTNAME= yammi -PORTVERSION= 1.0rc1 +PORTVERSION= 1.0.r1 CATEGORIES= audio MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= ${PORTNAME} -DISTNAME= ${PORTNAME}-${PORTVERSION:S/.0/.0-/} +DISTNAME= ${PORTNAME}-${PORTVERSION:S/.0.r/.0-rc/} MAINTAINER= avleeuwen@piwebs.com COMMENT= A QT-based music manager with fuzzy search @@ -22,6 +22,8 @@ USE_QT_VER= 3 USE_GMAKE= yes GNU_CONFIGURE= yes +CONFIGURE_ENV= CXXFLAGS="${CXXFLAGS} ${PTHREAD_CFLAGS}" \ + LDFLAGS="${LDFLAGS} ${PTHREAD_LIBS}" CONFIGURE_ARGS+= --program-prefix='' USE_REINPLACE= yes @@ -32,7 +34,7 @@ .endif # exists(${LOCALBASE}/bin/noatun) .if defined(WITH_NOATUN) -BUILD_DEPENDS+= noatun:${PORTSDIR}/multimedia/kdemultimedia3 +BUILD_DEPENDS+= noatun:${PORTSDIR}/multimedia/kdemultimedia3 WITH_KDE=yes .endif # defined(WITH_NOATUN) --Boundary-00=_56ce/EhiYUt0Aq+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200309302220.h8UMKDiR064534>