Date: Mon, 26 Apr 2010 09:02:35 -0700 From: Julian Elischer <julian@elischer.org> To: Stefan Esser <se@FreeBSD.org> Cc: "Li, Qing" <qing.li@bluecoat.com>, freebsd-stable@freebsd.org, "Prokofiev S.P." <proks@skylinetele.com>, freebsd-net@freebsd.org, Qing Li <qingli@freebsd.org>, freebsd-current@freebsd.org, Marin Atanasov <dnaeon@gmail.com> Subject: Re: net/mpd5, ppp, proxy-arp issues Message-ID: <4BD5B91B.2050606@elischer.org> In-Reply-To: <4BD54AC7.7090301@FreeBSD.org> References: <B583FBF374231F4A89607B4D08578A430619B993@bcs-mail03.internal.cacheflow.com> <4B28F841.1070900@skylinetele.com> <i2o717f7a3e1004182353v7ead46b8g899c2e021d2dee42@mail.gmail.com> <w2t9ace436c1004191050n97692c4fq3d76e6becc5b354f@mail.gmail.com> <k2q717f7a3e1004192300r44d2c4aem5568c9e412f8b6f2@mail.gmail.com> <j2q9ace436c1004200103n336f8118teb45c3ebacec8239@mail.gmail.com> <o2w717f7a3e1004221143p6fafa849t8da52a6aa5be3bac@mail.gmail.com> <4BD54AC7.7090301@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/26/10 1:11 AM, Stefan Esser wrote: > Am 22.04.2010 20:43, schrieb Marin Atanasov: >> Hello, >> >> Thanks a lot for the patch, Qing! >> >> It works fine. However I've noticed one thing, after I start mpd5 and >> connect to my home network: >> >> kernel: WARNING: attempt to domain_add(netgraph) after domainfinalize() >> >> Not very sure if this is something to worry about or not? > > There was a problem with the initialization order of network "domains", > which caused kernel crashes with ISDN+INET6 some two years ago. The > reason was, that there was an implicit assumption, that all domains > were initialized when the network interfaces are initialized, with > NULL dereferences if domains are added (and relevant to a device) > after the device has been initialized. > > I debugged this problem and prepared a patch for discussion, which > later was committed by Max Laier (if memory serves me right). The > message was added in order to identify further situations, where > network domains are added after network interfaces have been > initialized. This message ought to be informational right now, since > the interface init is repeated whenever a network domain is added > as part of above mentioned patch. Init order should be fixed, if > this message is printed for compiled in drivers, but in case of a > kernel module (like netgraph) that adds a domain, it is unadvoidable > that the init order is reversed. > > Perhaps the message should be made conditional on the start-up of > the kernel not having finished, or it should be completely removed, > since time has shown, that the init order is correct in general. > > I'll remove that message (or make it conditional on "bootverbose") > unless there is opposition to this change ... please do.. it's an unavoidable thing that domains added after boot are done after boot completes :-) > Regards, STefan > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BD5B91B.2050606>