Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 26 Apr 2009 20:54:57 +0000 (UTC)
From:      Alan Cox <alc@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r191531 - head/sys/vm
Message-ID:  <200904262054.n3QKsv2N094233@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: alc
Date: Sun Apr 26 20:54:57 2009
New Revision: 191531
URL: http://svn.freebsd.org/changeset/base/191531

Log:
  Eliminate an archaic band-aid.  The immediately preceding comment already
  explains why the band-aid is unnecessary.
  
  Suggested by:	tegge

Modified:
  head/sys/vm/vm_fault.c

Modified: head/sys/vm/vm_fault.c
==============================================================================
--- head/sys/vm/vm_fault.c	Sun Apr 26 19:16:32 2009	(r191530)
+++ head/sys/vm/vm_fault.c	Sun Apr 26 20:54:57 2009	(r191531)
@@ -916,13 +916,11 @@ vnode_locked:
 	KASSERT(fs.m->oflags & VPO_BUSY,
 		("vm_fault: page %p not busy!", fs.m));
 	/*
-	 * Sanity check: page must be completely valid or it is not fit to
+	 * Page must be completely valid or it is not fit to
 	 * map into user space.  vm_pager_get_pages() ensures this.
 	 */
-	if (fs.m->valid != VM_PAGE_BITS_ALL) {
-		vm_page_zero_invalid(fs.m, TRUE);
-		printf("Warning: page %p partially invalid on fault\n", fs.m);
-	}
+	KASSERT(fs.m->valid == VM_PAGE_BITS_ALL,
+	    ("vm_fault: page %p partially invalid", fs.m));
 	VM_OBJECT_UNLOCK(fs.object);
 
 	/*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904262054.n3QKsv2N094233>