Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Jan 2014 17:47:33 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r260719 - in head/sys: kern sys
Message-ID:  <20140116134733.GB32734@FreeBSD.org>
In-Reply-To: <201401161345.s0GDjgqM016546@svn.freebsd.org>
References:  <201401161345.s0GDjgqM016546@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 16, 2014 at 01:45:42PM +0000, Gleb Smirnoff wrote:
T> Author: glebius
T> Date: Thu Jan 16 13:45:41 2014
T> New Revision: 260719
T> URL: http://svnweb.freebsd.org/changeset/base/260719
T> 
T> Log:
T>   Simplify wait/nowait code, eventually killing last remnant of
T>   historical mbuf(9) allocator flag.
T>   
T>   Sponsored by:	Nginx, Inc.
T> 
T> Modified:
T>   head/sys/kern/uipc_socket.c
T>   head/sys/sys/mbuf.h

The mbuf.h should have been committed separately:

T> Modified: head/sys/sys/mbuf.h
T> ==============================================================================
T> --- head/sys/sys/mbuf.h	Thu Jan 16 13:44:47 2014	(r260718)
T> +++ head/sys/sys/mbuf.h	Thu Jan 16 13:45:41 2014	(r260719)
T> @@ -466,14 +466,6 @@ struct mbuf {
T>  				   a non-initialized mbuf */
T>  
T>  /*
T> - * Compatibility with historic mbuf allocator.
T> - */
T> -#define	MBTOM(how)	(how)
T> -#define	M_DONTWAIT	M_NOWAIT
T> -#define	M_TRYWAIT	M_WAITOK
T> -#define	M_WAIT		M_WAITOK
T> -
T> -/*
T>   * String names of mbuf-related UMA(9) and malloc(9) types.  Exposed to
T>   * !_KERNEL so that monitoring tools can look up the zones with
T>   * libmemstat(3).

... with a comment:

Put an end to uncontrollable breeding of historical flags.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140116134733.GB32734>