Date: Fri, 25 Oct 2002 09:52:08 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: current@FreeBSD.ORG, Nate Lawson <nate@root.org> Subject: Re: libgtop port and v_tag changes Message-ID: <XFMail.20021025095208.jhb@FreeBSD.org> In-Reply-To: <1035510912.33175.5.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25-Oct-2002 Joe Marcus Clarke wrote: > On Thu, 2002-10-24 at 19:13, Nate Lawson wrote: >> On Thu, 24 Oct 2002, John Baldwin wrote: >> > Speaking of v_tag, can you fix the devel/libgtop port on current? >> > This is the patch I used to get it building the other day: >> > >> > > cat patch-sysdeps_freebsd_procmap.c >> > --- sysdeps/freebsd/procmap.c.orig Tue Oct 15 20:00:35 2002 >> > +++ sysdeps/freebsd/procmap.c Tue Oct 15 20:05:54 2002 >> > @@ -251,6 +251,7 @@ >> > &vnode, sizeof (vnode)) != sizeof (vnode)) >> > glibtop_error_io_r (server, "kvm_read (vnode)"); >> > >> > +#if __FreeBSD_version < 500000 >> > if ((vnode.v_type != VREG) || (vnode.v_tag != VT_UFS) || >> > !vnode.v_data) continue; >> > >> > @@ -261,6 +262,7 @@ >> > >> > maps [i-1].inode = inode.i_number; >> > maps [i-1].device = inode.i_dev; >> > +#endif >> > #endif >> > } while (entry.next != first); >> > >> > -- >> > >> > John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ >> > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ >> >> I assume Joe has a better version he planned to commit as referenced by >> this email: >> >> <1033747570.319.16.camel@gyros.marcuscom.com> >> >> I like his patch better because it still handles the non CURRENT case. >> Joe? > > I committed my patch to libgtop and libgtop2 a while ago. It should > work on both -CURRENT, not so -CURRENT, and -stable. Checkout patch-ah > in libgtop/files. Works like a champ on -CURRENT from Monday. It does?! v_tag is a pointer to kernel memory, you can't read that from userland! You would get a SIGSEGV and die as soon as you do the 'strcmp()'. That's why I #ifdef'd the whole chunk out. Also, just for the record, my code didn't break the non CURRENT case. :) -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021025095208.jhb>