Date: Fri, 3 Sep 2010 08:23:55 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Justin T. Gibbs" <gibbs@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r212160 - in head/sys: cam/ata cam/scsi cddl/contrib/opensolaris/uts/common/fs/zfs geom geom/sched kern sys Message-ID: <20100903062355.GB1780@garage.freebsd.pl> In-Reply-To: <4C802028.4040400@FreeBSD.org> References: <201009021940.o82JeS8M017537@svn.freebsd.org> <20100902213926.GA2542@garage.freebsd.pl> <4C802028.4040400@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--pvezYHf7grwyp3Bc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2010 at 04:07:36PM -0600, Justin T. Gibbs wrote: > On 9/2/2010 3:39 PM, Pawel Jakub Dawidek wrote: > > Don't you think it would be better to set the flag from within > > g_io_request()? This way every BIO_FLUSH consumer doesn't have to > > remember to set it. Or am I missing something? >=20 > I don't feel strongly one way or the other, but I thought that > g_io_request()'s job was to execute the request and to test invariants, > not to set policy. Perhaps I misinterpreted it's role. Does BIO_FLUSH make sense without BIO_ORDERED? My understanding is that it doesn't. But we still want BIO_ORDERED for use with BIO_WRITE for write barriers without cache flushing. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --pvezYHf7grwyp3Bc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkyAlHsACgkQForvXbEpPzRCZwCg1/3tHQmYuao+m9qF9Nvj2jbH 1DIAn3unwLCsDxs5fiyrOYDeOSHbOl4d =dskq -----END PGP SIGNATURE----- --pvezYHf7grwyp3Bc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100903062355.GB1780>