Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Jan 2010 19:49:56 GMT
From:      Rob Farmer <rfarmer@predatorlabs.net>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/143064: [PATCH] sysutils/gnome-system-tools Fix build without utmp.h
Message-ID:  <201001211949.o0LJnujo003393@www.freebsd.org>
Resent-Message-ID: <201001211950.o0LJo7xt043962@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         143064
>Category:       ports
>Synopsis:       [PATCH] sysutils/gnome-system-tools Fix build without utmp.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 21 19:50:07 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Rob Farmer
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD pentium4.predatorlabs.net 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r202659: Tue Jan 19 16:02:39 PST 2010     rfarmer@pentium4.predatorlabs.net:/obj/usr/src/sys/PENTIUM4  i386
>Description:
Switch from using UT_NAMESIZE to MAXLOGNAME - 1 to remove utmp.h include
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN gnome-system-tools.old/files/patch-src_users_user-settings.c gnome-system-tools/files/patch-src_users_user-settings.c
--- gnome-system-tools.old/files/patch-src_users_user-settings.c	2010-01-20 22:04:57.000000000 -0800
+++ gnome-system-tools/files/patch-src_users_user-settings.c	2010-01-20 22:29:44.000000000 -0800
@@ -1,6 +1,24 @@
---- src/users/user-settings.c.orig	Sun Apr 22 23:32:58 2007
-+++ src/users/user-settings.c	Sun Apr 22 23:34:18 2007
-@@ -632,10 +632,10 @@
+--- src/users/user-settings.c.orig	2009-12-15 05:17:23.000000000 -0800
++++ src/users/user-settings.c	2010-01-20 22:25:39.000000000 -0800
+@@ -29,7 +29,7 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
+ #include <stdlib.h>
+-#include <utmp.h>
++#include <sys/param.h>
+ #include <ctype.h>
+ 
+ #include "users-table.h"
+@@ -367,7 +367,7 @@
+ {
+ 	gint max_len;
+ #ifdef __FreeBSD__
+-	max_len = UT_NAMESIZE;
++	max_len = MAXLOGNAME - 1;
+ #else
+ 	struct utmp ut;
+ 
+@@ -819,10 +819,10 @@
  		password_changed = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (widget), "changed"));
  
  		if (password_changed)
@@ -12,4 +30,4 @@
 +		oobs_user_set_crypted_password (user, gtk_entry_get_text (GTK_ENTRY (widget)));
  	}
  
- 	group = get_main_group (oobs_user_get_login_name (user));
+ 	/* allowed to login without password? */


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001211949.o0LJnujo003393>