Date: Mon, 13 Dec 1999 17:59:24 +0000 From: Brian Somers <brian@Awfulhak.org> To: "CHOI, Junho" <cjh@wdb.co.kr> Cc: Jon Hamilton <hamilton@pobox.com>, current@FreeBSD.ORG, stable@FreeBSD.ORG, brian@hak.lan.Awfulhak.org Subject: Re: ppp over pty: trying to detect CD Message-ID: <199912131759.RAA00338@hak.lan.Awfulhak.org> In-Reply-To: Message from "CHOI, Junho" <cjh@wdb.co.kr> of "12 Dec 1999 19:16:52 %2B0900." <86bt7wlazv.fsf@gradius.myhome>
next in thread | previous in thread | raw e-mail | index | archive | help
Ah, I see the problem. I have a fix - I'm about to apply it to -current and ask jkh for permission to MFC. I've attached the -stable patch for your viewing enjoyment.... > >>>>> "JH" == Jon Hamilton <hamilton@pobox.com> writes: > > JH> Running -current from this afternoon, I am having a strange > JH> symptom with ppp over a pty; ppp does not detect that the pty > JH> does not support carrier, and will cycle once per second > JH> waiting for CD to appear. Putting ``set cd off'' in my > JH> ppp.conf for that target fixed the problem, but I thought I'd > JH> mention it nonetheless, since that didn't used to be > JH> required. Certainly not all that big a deal, but I thought it > JH> was worth a mention. > > JH> FreeBSD 4.0-CURRENT #13: Sat Dec 11 20:31:42 CST 1999 > > I am using 3-STABLE but I have the same problem with you. I think it > comes after adding pppoe support in pppd(after 3.3-RELEASE). I am > -STABLE user but I had to back to 3.3-RELEASE's ppp... I am using ADSL > service with pptpclient. > > JH> and the syslog with debugging turned on, with no "set cd" in the config: > > JH> Dec 11 20:48:20 woodstock ppp[3106]: tun1: Debug: deflink: Using tty_Timeout [0x8072d44] > JH> Dec 11 20:48:20 woodstock ppp[3106]: tun1: Debug: Waiting for carrier > JH> Dec 11 20:48:21 woodstock ppp[3106]: tun1: Debug: deflink: Using tty_Timeout [0x8072d44] > JH> Dec 11 20:48:21 woodstock ppp[3106]: tun1: Debug: Waiting for carrier > > JH> [ and on and on and on ] > > -- > +++ Any opinions in this posting are my own and not those of my employers +++ > CHOI, Junho <mailto:cjh@kr.freebsd.org> <http://www.kr.freebsd.org/~cjh>; > - Korea FreeBSD Users Group <http://www.kr.FreeBSD.org>; > - Public Service, Youido Post Office - Web Data Bank <http://www.wdb.co.kr>; -- Brian <brian@Awfulhak.org> <brian@FreeBSD.org> <http://www.Awfulhak.org>; <brian@OpenBSD.org> Don't _EVER_ lose your sense of humour ! <brian@FreeBSD.org.uk> Index: tty.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/ppp/tty.c,v retrieving revision 1.12.2.3 diff -u -r1.12.2.3 tty.c --- tty.c 1999/11/19 23:48:04 1.12.2.3 +++ tty.c 1999/12/13 07:30:44 @@ -112,6 +112,7 @@ log_Printf(LogDEBUG, "%s: ioctl error (%s)!\n", p->link.name, strerror(errno)); timer_Stop(&dev->Timer); + dev->mbits = TIOCM_CD; return; } } else @@ -187,8 +188,7 @@ return CARRIER_PENDING; /* Not yet ! */ } - return Online(dev) || !p->cfg.cd.necessity == CD_REQUIRED ? - CARRIER_OK : CARRIER_LOST; + return Online(dev) ? CARRIER_OK : CARRIER_LOST; } static int To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199912131759.RAA00338>